From: Reece Dunn (msclrhd_at_[hidden])
Date: 2006-06-10 13:52:52
Ilya Sokolov wrote:
> Andrei Melnikov wrote:
> > It's hard to review such large patches. I think it's better to
> > separate it into several smaller patches. I think you should at least
> > extract "minor non-functional code cleanups" into a separate patch. I
> > think such cleanups are definitely improvements, and the subpatch
> > should be applied immediately before the discussion of proposed
> > <toolset>-cpp-pch framework can start.
> ok, see latest patches. line endings in pch.jam are broken, so i sent my
> version of this file instead of diffs.
> > P.S. Due to some reason, the attachments have Content-disposition:
> > inline, and gmail web interface (correctly) refuses to recognize them
> > as attachments, so I couldn't save them.
> sorry, i cant find any options in thunderburd to resolve this issue
I could download the patches fine, and have applied the fixes from the
other e-mail to my local BBv2 branch. However, I keep getting
bash-2.05b$ patch < dmc.diff
patching file dmc.jam
patch: **** unexpected end of file in patch
when applying the PCH support ones using patch 2.5.8 :(. However,
looking at the patch, here are a few comments:
(1) You have added an additional pch_base.jam file -- is there a reason
for this. I.e. could you not move that code into pch.jam?
(2) In the gcc.jam fix, the import pch_base is commented out.
(3) Isn't there a way to provide a universal pch-c and pch-cpp rule that
msvc, dmc and gcc provide generators for? NOTE: I haven't looked at
this in too much detail.
(4) The msvc PCH support doesn't seem to have some of the updates
that people have posted to fix some of the issues with the msvc PCH
support. I believe there is more information on the BBv2 tracker.
(5) Overall it looks good :) although I haven't been able to test it yet.
(6) Now... how to provide cw-pch support...? :)
Express yourself instantly with MSN Messenger! Download today it's FREE!
Boost-Build list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk