Re: [Boost-build] BBv2 msvc.jam: An attempt to reduce code duplication in actions

From: Andrei Melnikov (andy.melnikov_at_[hidden])
Date: 2006-06-22 15:25:28

On 22/06/06, Rene Rivera <grafik.list_at_[hidden]> wrote:
> Andrei Melnikov wrote:
> > And what about "on" rule? Do I use it correctly?
>
> Oops, forgot to answer that one :-) It looks ok, I don't think you need
> the "bind PCH_..." now that you don't use those in the actions, I don't
> think they where needed in the first place.

Ok. I'll prepare the next version of the patch. I'm going to change
the pch rules too now. And I think the linker rules deserve a separate
patch in order to keep diffs small.

> Only other comment I have is
> to not use tabs ;-)

Well, in the patch tabs are only on "-" lines. This means that I
forgot to fix tabs when I committed my previous patch to CVS, and now
I'm fixing my mistake. I hope there are no tabs in other places.

Andrei