Re: [Boost-build] BBv2 msvc.jam: An attempt to reduce code duplication in actions

From: Reece Dunn (msclrhd_at_[hidden])
Date: 2006-06-29 11:19:27

Andrei Melnikov wrote:
> On 27/06/06, Andrei Melnikov <andy.melnikov_at_[hidden]> wrote:
> > On 24/06/06, Reece Dunn <msclrhd_at_[hidden]> wrote:
> > > Andrei Melnikov wrote:
> > > > Patch version 2.
> > > > - No cl.exe command line duplication any more, including compile.pch rule
> > > > - Whitespace cleanup: tab fix from my previous patch, some trailing
> > > > space removal
> > >
> > > Very nice! I have applied this to my local BBv2 branch and built a project
> > > without any problems. This has my vote :).
> >
> > Unfortunately, it doesn't work as expected. Full builds are ok, but
> > incremental builds fail. I think it's because it's incorrect to invoke
> > build rules with actions from other rules this way. Can someone help?
> >
> LOL... I just used -n switch for incremental build in VS... No wonder
> that it didn't work.

:)

> Could someone test my refactorings under Cygwin and review the code
> for possible flaws? I'm really afraid of checking changes in just
> because "they just work", without multiplatform testing and a peer
> code review.

I merged your changes into BBv2 on my machine and I always use the
bash/cygwin environment. I have been succesfully using your patch for
a while now :).

- Reece
_________________________________________________________________
Try Live.com: where your online world comes together - with news, sports, weather, and much more.
http://www.live.com/getstarted