Re: [Boost-build] wxWidgets support files

From: Vladimir Prus (ghost_at_[hidden])
Date: 2006-08-21 09:50:48

On Saturday 12 August 2006 22:37, Alex Besogonov wrote:
> Bojan Resnik wrote:
> >> >   However, if I try to put the version explicitly, like
> >> >            using wxWidgets : E:/wx : 2.6 ;
> >> >   it doesn't work anymore (complains about not being able to find
> >> > wxbaseud.lib).
> >>
> >> Fixed. Please, try the attached patches.
> >
> >   Sorry for the delay, I was on vacation. These patches have fixed the
> > problems I was having. Can wxWidgets support become a standard part of
> > Boost.Build?
>
> Yes, I hope so.
>
> 2Vladimir Prus: what do I need to do in order to include wxWidgets.jam
> to the official Boost distribution?

There are some formatting issues with the last set of files that make review a 
bit hard:

   - you mix tabs and spaces, in V2, we always use just spaces, and there 
     should be 4 spaces per indent level
   - there should be no lines longer than 80 characters

This is documented in hacking.txt as well as other conventions. For example, 
instead of:

                return $(res:J="") ;
        } else
        {

you should have

                return $(res:J="") ;
        } 
     else
        {

However, the first two issues are more important. Can you please fix those and 
then send again complete set of most recent files for me to review?	
        
> PS: I can also be contacted via ICQ: 110656836

Thanks! I'll use that if we need to discuss something in real time.

- Volodya

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build V2: http://boost.org/boost-build2