Re: [Boost-build] [v2] Darwin patch for -F option to ld

From: David Abrahams (dave_at_[hidden])
Date: 2006-09-27 19:05:10

Rene Rivera <grafikrobot_at_[hidden]> writes:

> David Abrahams wrote:
>> "K. Noel Belcourt" <kbelco_at_[hidden]> writes:
>> 
>>> Hi,
>>>
>>> Not sure when the -F framework option was introduced into the
>>> darwin.jam, 
>> 
>> Just days ago.
>> 
>>> but I believe it is erroneous to pass -F to ld without an
>>> argument.  
>> 
>> That shouldn't happen.  If it's happening; I think it's a bjam bug,
>
> It's a bjam bug. I added a test in tools/jam/test that verifies the 
> problem exists. "$(x:D)", when x doesn't have a dir, is returning an 
> empty string instead of an empty list:
>
> C:\DevRoots\Boost\boost\tools\jam\test>..\src\bin.ntx86\bjam -f test.jam
> --- Testing SHELL builtin...
> --- Testing W32_GETREGNAMES builtin...
> --- Testing var expansion...
> --- Testing var on target semantics...
> --- Testing var expansion...
> var_expand.jam:14: error: [FAILED] '' (==)
> --- Complete: PASSED(25) *FAILED(1)*

Oooooooooh.  I ran some tests, but I never considered the possibility
that there would be no directory.  Whether or not that's a bug is
certainly open to debate, though.  Consider:

     $(y:D=$(x:D))  # locate y in x's directory

Unless there's a spec somewhere that details the behavior of $(x:D)
when x has no "/" in it (and maybe even if there is), I think we
should leave the jam core alone to avoid breaking code.  I'll check in
a fix for this case in darwin.jam.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com