Re: [Boost-build] PCH changes

From: Vladimir Prus (ghost_at_[hidden])
Date: 2006-10-08 04:13:06

On Sunday 08 October 2006 12:01, Bojan Resnik wrote:

> > I've also committed automated test for PCH functionality, which works on
> > gcc.
> >
> > I was no able to test with msvc, although I carefully looked at command
> > lines, and they look correct. I'd appreciate if somebody test this on
> > msvc, and try running the 'pch.py' test as well.
> >
> > Finally, an example 'pch' was added to the example directory.
> >
> > - Volodya
>
>   Hi, Vladimir.
>   I ran the tests today with CVS head, using all versions of MSVC on
> my machine. The commands were
>       set DO_DIFF=diff
>       test_all.py msvc-6.0 > msvc-6.0.txt 2>&1
>       test_all.py msvc-7.1 > msvc-7.1.txt 2>&1
>       test_all.py msvc-8.0 > msvc-8.0.txt 2>&1
>
>   There are errors and failed tests, but the results are pretty much
> the same with all these compilers. Attached is the MSVC 8 output.

Hi Bojan,
thanks for trying. In fact, I would not expect any direct breakage with Boost 
tests, just  because we don't enable PCH for Boost itself, but it's 
reassuring to know I did not accidentally broken something else.

>   I also ran the pch.py test with the command lines
>       pch.py msvc-6.0
>       pch.py msvc-7.1
>       pch.py msvc-8.0
>   and they completed fine, after I patched pch.py to use #include
> "pch.hpp" instead of #include <pch.hpp>. The patch is also attached.

Can you check if changing:

   cpp-pch pch : pch.hpp : <toolset>msvc:<source>pch.cpp ;

to

   cpp-pch pch : pch.hpp : <toolset>msvc:<source>pch.cpp <include>. ;

instead of changing the form of includes fixes the problem?

Thanks,
Volodya