|
Boost-Build : |
From: Rene Rivera (grafikrobot_at_[hidden])
Date: 2007-08-06 12:40:57
Roland Schwarz wrote:
> Roland Schwarz wrote:
>> I attached a small patch, so -d+4 will also
>> show the batchfiles content.
>
> Feedback welcome.
Functionally it looks fine. But I think it could be made simpler, I know
three lines seems simple, by:
* Setting the command_orig, unconditionally at the top when it's declared.
* Which removes the need for the assignment in the "if".
* And move the restoring it further up, and add an explanatory comment,
to before the start command block.
-- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org - grafik/redshift-software.com -- 102708583/icq - grafikrobot/aim - grafikrobot/yahoo
Boost-Build list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk