Re: [Boost-build] Incorrect exit status if process abends

From: Robert Ramey (ramey_at_[hidden])
Date: 2007-11-09 20:48:54

On november 2, I reported that it does.

Here is the tail of a bjam.log in which a test fails with an assertion
but is reported as passed.

>> ..\..\..\bin.v2\libs\serialization\build\gcc-3.4.4\debug\link-static
>> \libboost_serialization-gcc34-d-1_34_1.a
>> gcc.link
>> ..\..\..\bin.v2\libs\serialization\test\test_shared_ptr_132_text_archiv
>> e.test\gcc-3.4.4\debug\link-static\test_shared_ptr_132_text_archive.exe
>> testing.capture-output
>> ..\..\..\bin.v2\libs\serialization\test\test_shared_ptr_1
>> 32_text_archive.test\gcc-3.4.4\debug\link-static\test_shared_ptr_132_text_archiv
>> e.run
>> ====== BEGIN OUTPUT ======
>> assertion "result.second" failed: file
>> "..\..\..\libs\serialization\src\extended
>> _type_info.cpp", line 75
>>
>> EXIT STATUS: 34304
>> ====== END OUTPUT ======
>> *passed*
>> ..\..\..\bin.v2\libs\serialization\test\test_shared_ptr_132_text_arch
>> ive.test\gcc-3.4.4\debug\link-static\test_shared_ptr_132_text_archive.test
>> ...updated 32 targets...

So I would expect that some tests are failing but are being reported
as passed.  On the other hand, I grepped the boost source and
assert is used only occasionally so I wouldn't think that including
this fix will have a huge impact.

Robert Ramey

Rene Rivera wrote:
> K. Noel Belcourt wrote:
>> There's a problem in execunix.c where I don't set the correct process
>> termination status if the process crashes or otherwise fails to exit
>> through normal channels (by calling exit() or_exit(), or exiting
>> through main).  This patch marks the process termination status as
>> having failed if it doesn't exit through normal channels.
>>
>> If there's no objection, I'll get this committed to trunk.
>
> No objection, only a question. Is this something that affects testing
> results?