Re: [Boost-build] Fixing intel-darwin linker symbols

From: Vladimir Prus (ghost_at_[hidden])
Date: 2008-04-24 01:09:03

On Thursday 24 April 2008 01:37:07 K. Noel Belcourt wrote:
> 
> On Apr 22, 2008, at 10:49 PM, Vladimir Prus wrote:
> 
> > On Wednesday 23 April 2008 03:32:45 K. Noel Belcourt wrote:
> >> The attached patch fixes these undefined symbols
> >>
> >> __ZNSt15basic_streambufIwSt11char_traitsIwEE8overflowEj
> >> __ZNSt15basic_streambufIwSt11char_traitsIwEE9pbackfailEj
> >>
> >> when building with the intel-darwin toolset.  The fix just defines -
> >> D__WINT_TYPE__=int to match the behavior of the darwin toolset.
> >
> > What does this macro affect? Is the intel-darwin compiler always
> > requires that macro to work?
> >
> >> I
> >> realize this patch is unorthodox in that it patches the c and c++
> >> build actions but this approach seems simpler than adding a new macro
> >> to Boost.config and going that route.  I'm all ears if someone has a
> >> better idea on how to patch this.
> >
> > I don't think we should bother with anything else, if this macro  
> > should
> > really be always defined. But in that case, I'd prefer to see a  
> > comment
> > explaining why it's so, so that in future nobody remove this setting.
> 
> I've made the patch a bit cleaner, moved the macro definition into  
> the init rule and only enable it for intel versions 9, 10.0, and  
> 10.1.  Okay to commit?

Seems fine. Thanks!

- Volodya