Re: [Boost-build] Patch rule numbers.log10

From: Rick Yang (rick68_at_[hidden])
Date: 2008-05-31 07:44:55

Hi Jurko Gospodnetiæ,

I use Boost.Build that in boost_1_35_0, so maybe I have got to use SVN.
I saw the change-set after commited it. :-p

Thank you for your reply.

Sincerely,
  Rick Yang

On Sat, May 31, 2008 at 7:02 PM, Jurko Gospodnetiæ <
jurko.gospodnetic_at_[hidden]> wrote:

>   Hi rick68.
>
> > ECHO [ numbers.log10 1 ] ;
> > ECHO [ numbers.log10 12 ] ;
> > ECHO [ numbers.log10 123 ] ;
> > ECHO [ numbers.log10 1234 ] ;
> > ECHO [ numbers.log10 12345 ] ;
> > ECHO [ numbers.log10 123456 ] ;
> > ECHO [ numbers.log10 1234567 ] ;
> > ECHO [ numbers.log10 12345678 ] ;
> > ECHO [ numbers.log10 123456789 ] ;
> > ECHO [ numbers.log10 1234567890 ] ;
> > ECHO [ numbers.log10 12345678900 ] ;
> >
> > and I got these result:
> > 1
> > 2
> > 3
> > 4
> > 5
> > 6
> > 7
> > 8
> > 9
> > 11
>
>    Actually, internal numbers.jam tests contain the following code:
>
>     assert.result 0 : log10 1 ;
>     assert.result 0 : log10 9 ;
>     assert.result 1 : log10 10 ;
>     assert.result 1 : log10 99 ;
>     assert.result 2 : log10 100 ;
>     assert.result 2 : log10 101 ;
>     assert.result 2 : log10 125 ;
>     assert.result 2 : log10 999 ;
>     assert.result 3 : log10 1000 ;
>     assert.result 10 : log10 12345678901 ;
>
>   and they all pass using the current trunk version so I do not really
> know which version you were using. To run them you can use 'bjam
> --debug-module=numbers'.
>
>   Also, running your code on that same version I get the following
> results: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 which all seem correct.
>
>   I remember there being a bug with numbers.log10, but it got fixed
> recently. See change-set:
>
>   http://svn.boost.org/trac/boost/changeset/45100
>
>   It also includes the exact change you are proposing. :-)
>
>   Hope this helps.
>
>   Best regards,
>     Jurko Gospodnetiæ
>
>
> P.S.
>
>   Usually it is easier to process your patch if you use the SVN patch
> format which also includes information on the exact file revisions they
> are comparing.
>
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost-build
>