Re: [Boost-build] Patch for generate.jam to generate to be wrapped by other rules

From: Jurko Gospodnetić (jurko.gospodnetic_at_[hidden])
Date: 2008-07-19 14:12:48

   Hi Jonathan.

> The generate main target currently only works if you pass it a 
> <generating-rule> using the '@' construction.  If you don't, it silently 
> just doesn't do anything.
> 
> Here's a patch that cleans this up so that it properly gives an error if 
> it can't run the <generating-rule>, and also just tries to call the rule 
> via indirect.call if no '@' prefix is found, which allows people to 
> write wrapper rules that use generate.

   I took a look at the patch now and it contains a fix for a copy/paste 
bug in some error-handling code in generate.jam but I do not understand 
why it should do any of the things you describe in your mail.

   As stated in my other post - I do not see why this place should allow 
specifying 'indirect rules' without the leading @ character.

   And the other thing is why you think the case when there is no 
<generating-rule> property is being silently ignored? As I see it that 
case is handled in the generated-target-class.__init__ rule. There could 
be a bug here and I have not taken the time to prepare a use-case and 
play with this but from looking at the code - I do not see a problem.

   Could you please prepare a test-case demonstrating the problems this 
patch is supposed to solve? See the Boost Build tools/build/v2/test 
folder for more information.

   Best regards,
     Jurko Gospodnetić