Re: [Boost-build] [PATCH] -ftemplate-depth

From: Ilya Sokolov (fal_delivery_at_[hidden])
Date: 2008-07-20 04:43:59

Jurko Gospodnetić wrote:
>   Hi Juergen.
> 
>   Thanks for the information.
> 
>   Here's a patch for the gcc.jam toolset module that should add the 
> template-depth feature you need.
> 
>   Please test it out and tell me if it does what you need.
> 
>   Note that Boost Build currently does not have support for cleanly 
> adding features allowing any positive integral number as its value (I 
> added a ticked for this at 
> https://zigzag.lvk.cs.msu.su:7813/boost.build/ticket/194) so I had to 
> implement smoe fixed set of allowed values. If you need any other value 
> you can easily call:
> 
>   feature.extend template-depth : 666 ;
> 
>   (replacing 666 with the value you need) in your Jamfile.
> 
> 
>   Anyone else has any suggestions on this patch?

I think it is better to append -ftemplate-depth-N to the OPTIONS 
variable. Or duplicate it in compile.c++.pch and compile.c.pch actions.

> Perhaps placing the 
> feature definition in a different module or renaming it to 
> gcc.template-depth? I though about placing it in the tools/builtin.jam 
> module but the feature is currently used only in the gcc toolset so I 
> decided against it.

qcc also have "template-depth".

>   Rene, would it be ok to commit this patch? It's a clean feature 
> addition with no effect on Boost Build tests on Windows and cygwin and 
> does not break any of the Boost library tests I tries on Windows. Since 
> nothing else uses a feature with this name and the feature's default 
> value (128) is equal to the previously hard-coded value I do not see how 
> this could affect existing builds unless they defined their own 
> template-depth feature.
> 
>   If the patch is OK, I'll commit it and update the docs.