Re: [Boost-build] Fwd: 1.35.0 && serialization && spirit && threadsafety

From: Robert Ramey (ramey_at_[hidden])
Date: 2008-07-26 14:27:33

>         /boost/thread//boost_thread                             # needed to
> add this as a dep b/c we need to link threads when we define

This seems like a very bad idea to me.  I hope this wasn't checked into the release branch.

I looks to me that this means that anyone using the serializaiton library is now depending
upon boost_thread in some way.  If this is the case - then its beyond a terrible idea-
it's just plain wrong.  That fact that it's used as a work around in your situation
where you only build for mult-threading is no excuse or reason that everyone else
should live with this.

Find another solution.

Robert Ramey
  "Tim St. Clair" <timothysc_at_[hidden]> wrote in message news:ef85fd8f0807240919t6732f575l5e94e0ad8411a5b0_at_mail.gmail.com...
  Sure that makes sense to me, I just wanted you to be aware that this error existed.  

  I put in a work around into my code (We only build in multithreaded).  

  Cheers,
  Tim

  On Thu, Jul 24, 2008 at 10:18 AM, Vladimir Prus <ghost_at_[hidden]> wrote:

    On Thursday 24 July 2008 18:50:41 Tim St. Clair wrote:
    > FYI...
    >
    > ---------- Forwarded message ----------
    > From: Tim St. Clair <timothysc_at_[hidden]>
    > Date: Tue, Jul 22, 2008 at 5:27 PM
    > Subject: 1.35.0 && serialization && spirit && thread safety
    > To: boost-users_at_[hidden]
    >
    >
    > I've seen info in various email-threads regarding thread safety when using
    > xml archives.
    > We had come across some assert conditions in multithreaded code, only to
    > trace down that (BOOST_SPIRIT_THREADSAFE) was not defined during boost
    > compilation.
    >
    > to fix, I modified the Jamfile.v2 for serialization:
    >
    > lib boost_serialization
    >      : $(SOURCES).cpp
    >         /boost/thread//boost_thread                             # needed to
    > add this as a dep b/c we need to link threads when we define
    > BOOST_SPIRIT_THREADSAFE
    >     : <define>BOOST_SPIRIT_THREADSAFE            # needed to add this as a
    > define
    >       <toolset>msvc:<cxxflags>/Gy
    >       <link>shared:<define>BOOST_SERIALIZATION_DYN_LINK=1
    >       <conditional>@include-spirit

    This does not seem right -- why would we link to boost_serialization in ST build?
    How about something like:

           <threading>multi:<define>BOOST_SPIRIT_THREADSAFE
           <threading>multi:<library>/boost/thread//boost_thread

    Note that I've no idea why BOOST_SPIRIT_THREADSAFE requires Boost.Thread, so I cannot
    comment on this logic.

    - Volodya
    _______________________________________________
    Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost-build

  -- 
  Regards,
  Timothy St. Clair
  [timothysc_at_[hidden]] 

------------------------------------------------------------------------------

  _______________________________________________
  Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost-build