Re: [Boost-build] Boost-1.36.0 FreeBSD patches for review

Subject: Re: [Boost-build] Boost-1.36.0 FreeBSD patches for review
From: Alexander Sack (pisymbol_at_[hidden])
Date: 2008-10-25 11:07:11

On Sat, Oct 25, 2008 at 8:47 AM, Alexander Sack <pisymbol_at_[hidden]> wrote:
> On Fri, Oct 24, 2008 at 10:11 PM, Steve M. Robbins <steve_at_[hidden]> wrote:
>> On Fri, Oct 24, 2008 at 08:49:30AM -0400, Alexander Sack wrote:
>>> On Fri, Oct 24, 2008 at 3:25 AM, Steve M. Robbins <steve_at_[hidden]> wrote:
>>> > On Thu, Oct 23, 2008 at 10:46:58PM -0400, Alexander Sack wrote:
>>> >
>>> >> In the meantime, I would like comments on the following three patches:
>>> >>
>>> >> - execution_monitor.ipp.patch
>>> >>
>>> >> I've ifdef'ed out the SIGNAL codes depending on the FreeBSD release as
>>> >> well as define SIGPOLL as SIGIO (FreeBSD 7 and above fixes this).  I
>>> >> made it several defines since different platforms might have some
>>> >> support but not all (wasn't sure, I was gong for maximum flexibility
>>> >> without being too #ifdef happy).
>>> >
>>> > I didn't look at your patch, but suggest instead the patch from
>>> > trac ticket 2152 http://svn.boost.org/trac/boost/ticket/2152
>>> > which does not require checking platform versions and is thus
>>> > more portable.  (And which has been applied to trunk)
>>>
>>> Steve that only applies to one signal code.
>>
>> Hm.  I misremembered what ticket 2152 was about and thought you were
>> addressing the same thing; after looking at your patch, I see that was
>> mistaken.  I should not have commented without reading your patch.
>> :-/
>
> Not a problem.  Ticket 2152 will definitely solve building it on
> modern freeBSD boxes so it should be part of my patch as well.
> However, does this patch actually look reasonable to you?  I'd like to
> get this into 1.37 if possible (it *should* be innocuous to anything
> other than FreeBSD).

Filed ticket with patch:

https://svn.boost.org/trac/boost/ticket/2435

Patch against trunk and updated.

Btw, I see for some reason there is a 2434 (browser issues with
button, can someone remove that bug, I tried but I don't know how -
doesn't look obvious).

-aps