Re: [Boost-build] Cleanup execunix.c

Subject: Re: [Boost-build] Cleanup execunix.c
From: Vladimir Prus (ghost_at_[hidden])
Date: 2010-01-06 12:20:15

On Wednesday 06 January 2010 02:13:58 K. Noel Belcourt wrote:

> Hi,
> 
> The attached patch ensures we close both file descriptors following  
> the dup2 call.  This is mostly for completeness but also because I've  
> occasionally noticed output isn't flushed from a terminated process  
> (when it is killed for exceeding the time limit).  I'm sure this  
> won't break anything and am slightly hopeful that it might ensure  
> output is flushed before the terminating process is killed.
> 
> Look reasonable?

Looks perfectly reasonable to me. Feel free to commit.

Thanks,
Volodya