Re: [Boost-build] Fop patch

Subject: Re: [Boost-build] Fop patch
From: Vladimir Prus (ghost_at_[hidden])
Date: 2010-11-06 11:50:56

On Saturday, October 30, 2010 16:34:55 Daniel James wrote:
> Hi,
> 
> Does this patch to the fop toolset look okay? It fixes a few things:
> 
> It adds 'import boostbook' because the type 'FO' is registered there
> and used in fop.jam. This was causing errors if 'using fop' came
> before 'using boostbook'.
> 
> If fixes the reinitialization check, which didn't work. Is this really
> needed?

Honestly, probably not. We only support a single version of fop,
and there's nothing wrong with allowing user-config.jam to override
fop settings from site-config.jam.

> It fixes the logic for setting JAVA_HOME and JAVACMD. Specifying the
> location of the java executable has been broken for 6 years(!), so it
> might be best of it's just removed?

I have this:

        using fop : /home/ghost/local/XEP/xep : /usr/lib/jvm/java-1.5.0-sun ;

and it appears to work. On the other hand, I never tried to set name of
the java executable. If it's broken now, then feel free to either fix it with
your patch, or remove this functionality.

Thanks,

-- 
Vladimir Prus
http://vladimir_prus.blogspot.com
Boost.Build: http://boost.org/boost-build2