Boost logo

Boost-Build :

Subject: Re: [Boost-build] Access violation patch
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2011-11-22 12:33:41


On 11/22/2011 08:19 AM, Juraj Ivančić wrote:
> On 22.11.2011. 15:46, Steven Watanabe wrote:
>> This is still wrong. The correct fix is
>> to save and restore frame_before_python_call.
>> Otherwise, you can get cases like this
>> bjam:
>> python:
>> bjam:
>> python
>> bjam_call -> returns None
> Right. I also missed check for zero in bjam_backtrace().

This new patch is way too complicated. It would
be better to just save the value on the stack
around PyObject_Call rather than creating a completely
separate stack. I already fixed this locally
because it was interfering with testing
other (major) changes that I'm working on.

In Christ,
Steven Watanabe

Boost-Build list run by bdawes at, david.abrahams at, gregod at, cpdaniel at, john at