Re: [Boost-build] Adding xsl:param based features to boostbook.

Subject: Re: [Boost-build] Adding xsl:param based features to boostbook.
From: Daniel James (dnljms_at_[hidden])
Date: 2011-12-07 18:04:46

On 7 December 2011 19:44, Steven Watanabe <watanabesj_at_[hidden]> wrote:
> AMDG
>
> On 12/07/2011 11:14 AM, Daniel James wrote:
>> Hi,
>>
>> This is a minor issue that I'm trying to fix for the doc build.
>> There's an '<xsl:param>' set in Jamroot which tells boostbook to use
>> the boost documentation settings (so that it will use the boost logo,
>> the shared css file and include the boost navigation links). It'd be
>> nice to be able to override it, so I tried implementing a boost build
>> feature that can be used instead. Hopefully, it's also be a bit more
>> pleasant to use. I don't really know what I'm doing so I've done this
>> on a branch. Can someone knowledgeable have a quick look to make sure
>> it's okay before I merge it to trunk:
>>
>> https://svn.boost.org/trac/boost/changeset/75848/
>>
>> I'm mainly worried about the changes to 'boostbook.jam', I just copied
>> the 'property-set' stuff from elsewhere, but there's also the
>> possibility that I'm going about this the wrong way.
>>
>
> It looks okay to me, though I'd be inclined to
> implement it as a composite feature instead of
> expanding it in boostbook-generator.

Sure, but that would involved creating individual features (so that
they can be overridden) and messing around with boost.root to get the
paths right. I'm more interested in following the path of least
resistance here. Build certainly could do more for boostbook (e.g. the
value of boost.root should be automatically set) but I'm not keen on
doing it.

Thanks for the review.