Boost logo

Boost-Build :

Subject: Re: [Boost-build] [Boost-commit] svn:boost r78575 - trunk/tools/build/v2/engine
From: Jurko Gospodnetić (jurko.gospodnetic_at_[hidden])
Date: 2012-05-25 06:25:47


>> Log:
>> Fixed Boost Jam crash when the SPLIT_BY_CHARACTERS rule gets passed an empty list as any of its arguments.
> Wouldn't it be better to change the
> signature so that empty lists are
> rejected? In fact, it looks like it
> was intended to be this way, but the
> args array is unused.

   I ran into the problem before, noticed the rule had no unit-tests and
so applied the simplest quick-fix I could think of to make the code 'not

   I planned on looking into it later again, updating the fix as needed,
discussing some border cases I noticed and preparing some unit tests -
might as well do it now.

   The fix is done - now invalid calls get reported correctly instead of
silently returning an empty list.

   I'll post some notes on SPLIT_BY_CHARACTERS usage and testing in a
separate thread soon. :-)

   Best regards,
     Jurko Gospodnetić

Boost-Build list run by bdawes at, david.abrahams at, gregod at, cpdaniel at, john at