Re: [Boost-build] embed manifest file

Subject: Re: [Boost-build] embed manifest file
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2014-03-28 16:13:49

AMDG

On 03/28/2014 12:32 PM, tr1gun wrote:
> Hello,
> 
> i want to embed a user-defined manifest in the build dll.
> i tried to extend the msvc-linking-generator and it seems now it
> correctly builds and embeds a user supplied manifest file.
> Can someone comment on the attached patch?
> I extended the msvc-linking-generator to create an extra target for
> embedding the manifest file. The extra target (MANIFESTLOG) is a dummy
> file as embedding the manifest file only modifies the dll without
> creating a new file.
> Is this the correct way?
> 

Creating a new target is wrong.  The action updates
the dll, so it should have the dll as its target.
It would be much simpler and more reliable if
you simply adjusted the check for <embed-manifest>on
in link and link.dll so that it first checks
whether a manifest file has been explicitly specified
and uses that instead of the default.

In Christ,
Steven Watanabe