Re: [Boost-build] Include list reversed in handle-flag-value()

Subject: Re: [Boost-build] Include list reversed in handle-flag-value()
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2015-02-28 12:48:24

AMDG

On 02/28/2015 10:35 AM, Nogradi, Chris wrote:
> 
> We have finally merged in the past years boost-build changes into our branch and have run into the following issue with this change:
> 
> SHA-1: 290e284ffeef6ffccb5c05db69398c47cd0cf1ea
> 
> * topological sort ordered includes.
> 
> It appears that this line in handle-flag-value() is reversing the order of the includes (the order rule is doing it):
> 
> 296:            result = [ $(order).order [ sequence.unique $(result) : stable ] ] ;
> 
> I hope this was not done on purpose since the change in behavior seems drastic as compared to what it was doing before.  In order to recover from this reversal, we are currently doing this:
> 
> 296:            result = [ $(order).order [ sequence.reverse [ sequence.unique $(result) : stable ] ] ] ;
> 
> Is this an oversight? Can the original behavior be restored? Is there a better way for us to restore the functionality without incurring an additional traversal over the list?
> 

It was a mistake.  However, if the order of your
includes matters, you probably shouldn't be relying
on the automatic order.  I'll fix this shortly.

In Christ,
Steven Watanabe