Boost logo

Boost-Commit :

From: danieljames_at_[hidden]
Date: 2007-07-01 07:54:23


Author: danieljames
Date: 2007-07-01 07:54:22 EDT (Sun, 01 Jul 2007)
New Revision: 7332
URL: http://svn.boost.org/trac/boost/changeset/7332

Log:
Move malloc_allocator into its own header so that the normal tests don't have
to depend on the exception testing code.

Added:
   sandbox/unordered/libs/unordered/test/helpers/allocator.hpp
Text files modified:
   sandbox/unordered/libs/unordered/test/helpers/invariants.hpp | 6 ++--
   sandbox/unordered/libs/unordered/test/objects/exception.hpp | 41 +--------------------------------------
   2 files changed, 5 insertions(+), 42 deletions(-)

Added: sandbox/unordered/libs/unordered/test/helpers/allocator.hpp
==============================================================================
--- (empty file)
+++ sandbox/unordered/libs/unordered/test/helpers/allocator.hpp 2007-07-01 07:54:22 EDT (Sun, 01 Jul 2007)
@@ -0,0 +1,53 @@
+
+// Copyright 2006-2007 Daniel James.
+// Distributed under the Boost Software License, Version 1.0. (See accompanying
+// file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
+
+#if !defined(BOOST_UNORDERED_TEST_MALLOC_ALLOCATOR_HEADER)
+#define BOOST_UNORDERED_TEST_MALLOC_ALLOCATOR_HEADER
+
+#include <cstddef>
+#include <cstdlib>
+#include <boost/limits.hpp>
+
+namespace test
+{
+ template <class T>
+ struct malloc_allocator
+ {
+ typedef std::size_t size_type;
+ typedef std::ptrdiff_t difference_type;
+ typedef T* pointer;
+ typedef T const* const_pointer;
+ typedef T& reference;
+ typedef T const& const_reference;
+ typedef T value_type;
+
+ template <class U> struct rebind { typedef malloc_allocator<U> other; };
+
+ malloc_allocator() {}
+ template <class Y> malloc_allocator(malloc_allocator<Y> const& x) {}
+ malloc_allocator(malloc_allocator const& x) {}
+
+ pointer address(reference r) { return &r; }
+ const_pointer address(const_reference r) { return &r; }
+
+ pointer allocate(size_type n) {
+ return static_cast<T*>(malloc(n * sizeof(T)));
+ }
+
+ pointer allocate(size_type n, const_pointer u) { return allocate(n); }
+ void deallocate(pointer p, size_type n) { free(p); }
+ void construct(pointer p, T const& t) { new(p) T(t); }
+ void destroy(pointer p) { p->~T(); }
+
+ size_type max_size() const {
+ return (std::numeric_limits<size_type>::max)();
+ }
+
+ bool operator==(malloc_allocator const& x) const { return true; }
+ bool operator!=(malloc_allocator const& x) const { return false; }
+ };
+}
+
+#endif

Modified: sandbox/unordered/libs/unordered/test/helpers/invariants.hpp
==============================================================================
--- sandbox/unordered/libs/unordered/test/helpers/invariants.hpp (original)
+++ sandbox/unordered/libs/unordered/test/helpers/invariants.hpp 2007-07-01 07:54:22 EDT (Sun, 01 Jul 2007)
@@ -13,6 +13,7 @@
 #include <cmath>
 #include "./metafunctions.hpp"
 #include "./helpers.hpp"
+#include "./allocator.hpp"
 
 namespace test
 {
@@ -23,7 +24,7 @@
         typedef typename X::key_type key_type;
         // Boost.Test was reporting memory leaks for std::set on g++-3.3.
         // So I work around it by using malloc.
- std::set<key_type, std::less<key_type>, test::exception::detail::malloc_allocator<key_type> > found_;
+ std::set<key_type, std::less<key_type>, test::malloc_allocator<key_type> > found_;
 
         typename X::const_iterator it = x1.begin(), end = x1.end();
         typename X::size_type size = 0;
@@ -32,9 +33,8 @@
             // to test either that keys are unique or that equivalent keys are
             // adjacent. (6.3.1/6)
             key_type key = get_key<X>(*it);
- if(found_.find(key) != found_.end())
+ if(!found_.insert(key).second)
                 BOOST_ERROR("Elements with equivalent keys aren't adjacent.");
- found_.insert(key);
 
             // Iterate over equivalent keys, counting them.
             unsigned int count = 0;

Modified: sandbox/unordered/libs/unordered/test/objects/exception.hpp
==============================================================================
--- sandbox/unordered/libs/unordered/test/objects/exception.hpp (original)
+++ sandbox/unordered/libs/unordered/test/objects/exception.hpp 2007-07-01 07:54:22 EDT (Sun, 01 Jul 2007)
@@ -14,8 +14,8 @@
 #include <boost/preprocessor/seq/elem.hpp>
 #include <boost/preprocessor/cat.hpp>
 #include <iostream>
-#include <cstdlib>
 #include "../helpers/fwd.hpp"
+#include "../helpers/allocator.hpp"
 #include <map>
 
 #define RUN_EXCEPTION_TESTS(test_seq, param_seq) \
@@ -185,43 +185,6 @@
         // the most convenient way.
         namespace
         {
- template <class T>
- struct malloc_allocator
- {
- typedef std::size_t size_type;
- typedef std::ptrdiff_t difference_type;
- typedef T* pointer;
- typedef T const* const_pointer;
- typedef T& reference;
- typedef T const& const_reference;
- typedef T value_type;
-
- template <class U> struct rebind { typedef malloc_allocator<U> other; };
-
- malloc_allocator() {}
- template <class Y> malloc_allocator(malloc_allocator<Y> const& x) {}
- malloc_allocator(malloc_allocator const& x) {}
-
- pointer address(reference r) { return &r; }
- const_pointer address(const_reference r) { return &r; }
-
- pointer allocate(size_type n) {
- return static_cast<T*>(malloc(n * sizeof(T)));
- }
-
- pointer allocate(size_type n, const_pointer u) { return allocate(n); }
- void deallocate(pointer p, size_type n) { free(p); }
- void construct(pointer p, T const& t) { new(p) T(t); }
- void destroy(pointer p) { p->~T(); }
-
- size_type max_size() const {
- return (std::numeric_limits<size_type>::max)();
- }
-
- bool operator==(malloc_allocator const& x) const { return true; }
- bool operator!=(malloc_allocator const& x) const { return false; }
- };
-
             struct memory_area {
                 void const* start;
                 void const* end;
@@ -252,7 +215,7 @@
             };
 
             typedef std::map<memory_area, memory_track, std::less<memory_area>,
- malloc_allocator<std::pair<memory_area const, memory_track> > >
+ test::malloc_allocator<std::pair<memory_area const, memory_track> > >
                 allocated_memory_type;
             allocated_memory_type allocated_memory;
             unsigned int count_allocators = 0;


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk