|
Boost-Commit : |
From: hinnant_at_[hidden]
Date: 2007-12-14 12:04:56
Author: hinnant
Date: 2007-12-14 12:04:56 EST (Fri, 14 Dec 2007)
New Revision: 42037
URL: http://svn.boost.org/trac/boost/changeset/42037
Log:
V1 issues 9a, 9b and 10.
Text files modified:
sandbox/committee/LWG/issues.html | 6 ++--
sandbox/committee/LWG/thread_library.html | 46 +++++++++------------------------------
2 files changed, 14 insertions(+), 38 deletions(-)
Modified: sandbox/committee/LWG/issues.html
==============================================================================
--- sandbox/committee/LWG/issues.html (original)
+++ sandbox/committee/LWG/issues.html 2007-12-14 12:04:56 EST (Fri, 14 Dec 2007)
@@ -106,7 +106,7 @@
thread with nothing more than the evaluation of a data member?
Probably should
be "callable type that is not a pointer to member data." </p>
-<p>9a. [thread.threads.constr] (30.2.1.2), thread(thread&&): the first two
+<p>✎ 9a. [thread.threads.constr] (30.2.1.2), thread(thread&&): the first two
postconditions are a bit confusing, because they use two different
techniques
to describe the result. Choose one or the other. Either "x.joinable() ==
@@ -114,12 +114,12 @@
"x.joinable() ==
false and x.get_id() == id()". I prefer the latter, but wouldn't
insist on it. </p>
-<p>9b. [thread.threads.assign] (30.2.1.2): here, the state of x after the
+<p>✎ 9b. [thread.threads.assign] (30.2.1.2): here, the state of x after the
operation is "a default constructed state." That's different from the
description for the effect of the move constructor. These two should
be worded
consistently. </p>
-<p>10. [thread.threads.member] (30.2.1.5), join(): "the joinable()
+<p>✎ 10. [thread.threads.member] (30.2.1.5), join(): "the joinable()
status" is
muddled. I think all the discussion of joining would benefit from
defining a
Modified: sandbox/committee/LWG/thread_library.html
==============================================================================
--- sandbox/committee/LWG/thread_library.html (original)
+++ sandbox/committee/LWG/thread_library.html 2007-12-14 12:04:56 EST (Fri, 14 Dec 2007)
@@ -755,9 +755,7 @@
<dt>Postconditions:</dt>
<dd>
-<code>get_id() == thread::id()</code>
-<br>
-<code>joinable() == false</code>
+<code>get_id() == id()</code>.
</dd>
<dt>Throws:</dt>
@@ -822,10 +820,7 @@
<dt>Postconditions:</dt>
<dd>
-<code>get_id() != thread::id()</code>
-<br>
-<code>joinable() == true</code>
-<br>
+<code>get_id() != id()</code>.
<code>*this</code> represents the newly started thread.
</dd>
@@ -845,21 +840,15 @@
<dl>
<dt>Effects:</dt>
<dd>
-Constructs an object of type <code>thread</code> from <code><var>x</var></code>.
+Constructs an object of type <code>thread</code> from <code><var>x</var></code>,
+and sets <code><var>x</var></code> to a default constructed state.
</dd>
<dt>Postconditions:</dt>
<dd>
-<code><var>x</var>.joinable() == false</code>
-<br>
-<code><var>x</var>.get_id() == thread().get_id()</code>.<br>
-<code>joinable()</code>
-returns the value of <code><var>x</var>.joinable()</code>
-prior to the start of construction.
-<br>
+<code><var>x</var>.get_id() == id()</code> and
<code>get_id()</code> returns the value of <code><var>x</var>.get_id()</code>
-prior to the
-start of construction.
+prior to the start of construction.
</dd>
<dt>Throws:</dt>
@@ -919,19 +908,9 @@
<dt>Postconditions:</dt>
<dd>
-<code><var>x</var>.joinable() == false</code>
-<br>
-<code><var>x</var>.get_id() == thread().get_id()</code>.
-</dd>
-
-<dd>
-<code>joinable()</code> returns the
-value of <code><var>x</var>.joinable()</code> prior to the
-assignment.
-<br>
-<code>get_id()</code> returns the value of <code><var>x</var>.get_id()</code>
-prior to the
-assignment.
+<code><var>x</var>.get_id() == id()</code>,
+and <code>get_id()</code> returns the value of <code><var>x</var>.get_id()</code>
+prior to the assignment.
</dd>
<dt>Throws:</dt>
@@ -1003,9 +982,8 @@
<dt>Postconditions:</dt>
<dd>
If <code>join()</code> throws an exception,
-the <code>joinable()</code> status remains unchanged.
-Otherwise, <code>joinable()</code> is <code>false</code>
-and <code>get_id() == id()</code>.
+the value returned by <code>get_id()</code> remains unchanged.
+Otherwise <code>get_id() == id()</code>.
</dd>
<dt>Throws:</dt>
@@ -1038,8 +1016,6 @@
<dt>Postconditions:</dt>
<dd>
-<code>joinable() == false</code>
-<br>
<code>get_id() == id()</code>.
</dd>
Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk