|
|
Boost-Commit : |
From: joaquin_at_[hidden]
Date: 2008-01-18 11:32:10
Author: joaquin
Date: 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
New Revision: 42847
URL: http://svn.boost.org/trac/boost/changeset/42847
Log:
review version
Text files modified:
sandbox/flyweight/boost/flyweight/assoc_container_factory.hpp | 2 +-
sandbox/flyweight/boost/flyweight/detail/archive_constructed.hpp | 2 +-
sandbox/flyweight/boost/flyweight/detail/handle_factory_adaptor.hpp | 6 +++---
sandbox/flyweight/boost/flyweight/detail/serialization_helper.hpp | 6 +++++-
sandbox/flyweight/boost/flyweight/hashed_factory.hpp | 22 +++++++++++-----------
sandbox/flyweight/boost/flyweight/intermodule_holder.hpp | 10 +++++-----
sandbox/flyweight/boost/flyweight/refcounted.hpp | 6 +++---
sandbox/flyweight/boost/flyweight/serialize.hpp | 1 -
sandbox/flyweight/boost/flyweight/set_factory.hpp | 20 ++++++++++----------
sandbox/flyweight/libs/flyweight/doc/acknowledgements.html | 16 ++++++++--------
sandbox/flyweight/libs/flyweight/doc/examples.html | 26 +++++++++++++-------------
sandbox/flyweight/libs/flyweight/doc/index.html | 7 ++++---
sandbox/flyweight/libs/flyweight/doc/reference/locking.html | 6 +++---
sandbox/flyweight/libs/flyweight/doc/reference/tracking.html | 14 +++++++-------
sandbox/flyweight/libs/flyweight/example/Jamfile.v2 | 2 +-
15 files changed, 75 insertions(+), 71 deletions(-)
Modified: sandbox/flyweight/boost/flyweight/assoc_container_factory.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/assoc_container_factory.hpp (original)
+++ sandbox/flyweight/boost/flyweight/assoc_container_factory.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -35,7 +35,7 @@
handle_type insert(const entry_type& x)
{
- return cont.insert(x).first;
+ return cont.insert(x).first;
}
void erase(handle_type h)
Modified: sandbox/flyweight/boost/flyweight/detail/archive_constructed.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/detail/archive_constructed.hpp (original)
+++ sandbox/flyweight/boost/flyweight/detail/archive_constructed.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -3,7 +3,7 @@
* (See accompanying file LICENSE_1_0.txt or copy at
* http://www.boost.org/LICENSE_1_0.txt)
*
- * See http://www.boost.org/libs/multi_index for library home page.
+ * See http://www.boost.org/libs/flyweight for library home page.
*/
#ifndef BOOST_FLYWEIGHT_DETAIL_ARCHIVE_CONSTRUCTED_HPP
Modified: sandbox/flyweight/boost/flyweight/detail/handle_factory_adaptor.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/detail/handle_factory_adaptor.hpp (original)
+++ sandbox/flyweight/boost/flyweight/detail/handle_factory_adaptor.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -13,8 +13,8 @@
#pragma once
#endif
-/* Given a Factory and a Handle type convertible from and implicitly
- * constructible to Factory::handle_type, handle_factory_adaptor
+/* Given a Factory and a Handle type constructible from and implicitly
+ * convertible to Factory::handle_type, handle_factory_adaptor
* adapts Factory to present Handle as the associated handle_type.
*/
@@ -32,7 +32,7 @@
handle_type insert(const Entry& x)
{
- return static_cast<handle_type>(base().insert(x));
+ return static_cast<handle_type>(base().insert(x));
}
private:
Modified: sandbox/flyweight/boost/flyweight/detail/serialization_helper.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/detail/serialization_helper.hpp (original)
+++ sandbox/flyweight/boost/flyweight/detail/serialization_helper.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -27,7 +27,11 @@
namespace detail{
-/* TODO:comment
+/* The serialization helper for flyweight<T> maps numerical IDs to
+ * flyweight exemplars --an exemplar is the flyweight object
+ * associated to a given value that appears first on the serialization
+ * stream, so that subsequent equivalent flyweight objects will be made
+ * to refer to it during the serialization process.
*/
template<typename Flyweight>
Modified: sandbox/flyweight/boost/flyweight/hashed_factory.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/hashed_factory.hpp (original)
+++ sandbox/flyweight/boost/flyweight/hashed_factory.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -42,13 +42,13 @@
multi_index::identity<Entry>,
typename boost::mpl::if_<
mpl::is_na<Hash>,
- hash<Value>,
- Hash
+ hash<Value>,
+ Hash
>::type,
typename boost::mpl::if_<
- mpl::is_na<Pred>,
- std::equal_to<Value>,
- Pred
+ mpl::is_na<Pred>,
+ std::equal_to<Value>,
+ Pred
>::type
>
>
@@ -57,11 +57,11 @@
typedef multi_index::multi_index_container<
Entry,
index_list,
- typename boost::mpl::if_<
- mpl::is_na<Allocator>,
- std::allocator<Entry>,
- Allocator
- >::type
+ typename boost::mpl::if_<
+ mpl::is_na<Allocator>,
+ std::allocator<Entry>,
+ Allocator
+ >::type
> container_type;
public:
@@ -69,7 +69,7 @@
handle_type insert(const Entry& x)
{
- return &*cont.insert(x).first;
+ return &*cont.insert(x).first;
}
void erase(handle_type h)
Modified: sandbox/flyweight/boost/flyweight/intermodule_holder.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/intermodule_holder.hpp (original)
+++ sandbox/flyweight/boost/flyweight/intermodule_holder.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -42,7 +42,7 @@
static instantiator instance;
return instance.get();
}
-
+
private:
struct instantiator
{
@@ -56,7 +56,7 @@
* that we call "new" in an unlocked situation, thus minimizing the
* chance of leaving dangling locks due to catastrophic failure.
*/
-
+
{
interprocess::scoped_lock<interprocess::named_mutex> lock(mutex);
ppref=seg.find_or_construct<referenced_instance*>(
@@ -75,7 +75,7 @@
}
}
if(!*ppref){
- std::auto_ptr<referenced_instance> apc(
+ std::auto_ptr<referenced_instance> apc(
new referenced_instance(segment_name));
interprocess::scoped_lock<interprocess::named_mutex> lock(mutex);
ppref=seg.find_or_construct<referenced_instance*>(
@@ -113,7 +113,7 @@
char mutex_name[128];
char segment_name[128];
-
+
const char* compute_mutex_name()
{
std::sprintf(
@@ -125,7 +125,7 @@
(unsigned)compute_hash(typeid(C).name(),1),
(unsigned)compute_hash(typeid(C).name(),2),
(unsigned)compute_hash(typeid(C).name(),3));
-
+
return mutex_name;
}
Modified: sandbox/flyweight/boost/flyweight/refcounted.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/refcounted.hpp (original)
+++ sandbox/flyweight/boost/flyweight/refcounted.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -36,16 +36,16 @@
{
public:
explicit refcounted_value(const Value& x_):
- x(x_),ref(0)
+ x(x_),ref(0)
{}
refcounted_value(const refcounted_value& r):
- x(r.x),ref(0)
+ x(r.x),ref(0)
{}
refcounted_value& operator=(const refcounted_value& r)
{
- x=r.x;
+ x=r.x;
return *this;
}
Modified: sandbox/flyweight/boost/flyweight/serialize.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/serialize.hpp (original)
+++ sandbox/flyweight/boost/flyweight/serialize.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -23,7 +23,6 @@
#include <memory>
/* Serialization routines for flyweight<T>.
- * TODO: comment
*/
namespace boost{
Modified: sandbox/flyweight/boost/flyweight/set_factory.hpp
==============================================================================
--- sandbox/flyweight/boost/flyweight/set_factory.hpp (original)
+++ sandbox/flyweight/boost/flyweight/set_factory.hpp 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -37,16 +37,16 @@
public assoc_container_factory_class<
std::set<
Entry,
- typename boost::mpl::if_<
- mpl::is_na<Compare>,
- std::less<Value>,
- Compare
- >::type,
- typename boost::mpl::if_<
- mpl::is_na<Allocator>,
- std::allocator<Entry>,
- Allocator
- >::type
+ typename boost::mpl::if_<
+ mpl::is_na<Compare>,
+ std::less<Value>,
+ Compare
+ >::type,
+ typename boost::mpl::if_<
+ mpl::is_na<Allocator>,
+ std::allocator<Entry>,
+ Allocator
+ >::type
>
>
{
Modified: sandbox/flyweight/libs/flyweight/doc/acknowledgements.html
==============================================================================
--- sandbox/flyweight/libs/flyweight/doc/acknowledgements.html (original)
+++ sandbox/flyweight/libs/flyweight/doc/acknowledgements.html 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -6,7 +6,7 @@
<title>Boost.Flyweight Documentation - Acknowledgements</title>
<link rel="stylesheet" href="style.css" type="text/css">
<link rel="start" href="index.html">
-<link rel="prev" href="tests.html">
+<link rel="prev" href="review_notes.html">
<link rel="up" href="index.html">
</head>
@@ -14,8 +14,8 @@
<h1><img src="../../../boost.png" alt="boost.png (6897 bytes)" align=
"middle" width="277" height="86">Boost.Flyweight Acknowledgements</h1>
-<div class="prev_link"><a href="tests.html"><img src="prev.gif" alt="tests" border="0"><br>
-Tests
+<div class="prev_link"><a href="review_notes.html"><img src="prev.gif" alt="review notes" border="0"><br>
+Review_notes
</a></div>
<div class="up_link"><a href="index.html"><img src="up.gif" alt="index" border="0"><br>
Index
@@ -28,7 +28,7 @@
<h3 align="center">Disclaimer: Boost.Flyweight is not a Boost library</h3>
<p>
-The following people has provided valuable feedback and suggestions during the
+The following people have provided valuable feedback and suggestions during the
development of the library: Ion Gaztañaga, Janek Kozicki, Tobias Schwinger,
Pavel Voženílek. Rosa Bernárdez has proofread the
documentation from the first drafts up to its present form.
@@ -52,8 +52,8 @@
<hr>
-<div class="prev_link"><a href="tests.html"><img src="prev.gif" alt="tests" border="0"><br>
-Tests
+<div class="prev_link"><a href="review_notes.html"><img src="prev.gif" alt="review notes" border="0"><br>
+Review_notes
</a></div>
<div class="up_link"><a href="index.html"><img src="up.gif" alt="index" border="0"><br>
Index
@@ -63,9 +63,9 @@
<br>
-<p>Revised November 27th 2007</p>
+<p>Revised January 16th 2008</p>
-<p>© Copyright 2006-2007 Joaquín M López Muñoz.
+<p>© Copyright 2006-2008 Joaquín M López Muñoz.
Distributed under the Boost Software
License, Version 1.0. (See accompanying file <a href="../../../LICENSE_1_0.txt">
LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
Modified: sandbox/flyweight/libs/flyweight/doc/examples.html
==============================================================================
--- sandbox/flyweight/libs/flyweight/doc/examples.html (original)
+++ sandbox/flyweight/libs/flyweight/doc/examples.html 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -6,23 +6,23 @@
<title>Boost.Flyweight Documentation - Examples</title>
<link rel="stylesheet" href="style.css" type="text/css">
<link rel="start" href="index.html">
-<link rel="prev" href="xxx.html">
+<link rel="prev" href="reference/tracking.html">
<link rel="up" href="index.html">
-<link rel="next" href="tests.html">
+<link rel="next" href="future_work.html">
</head>
<body>
<h1><img src="../../../boost.png" alt="boost.png (6897 bytes)" align=
"middle" width="277" height="86">Boost.Flyweight Examples</h1>
-<div class="prev_link"><a href="xxx.html"><img src="prev.gif" alt="xxx" border="0"><br>
-<font color="#ff0000">[not linked yet]</font>
+<div class="prev_link"><a href="reference/tracking.html"><img src="prev.gif" alt="tracking policies" border="0"><br>
+Tracking policies
</a></div>
<div class="up_link"><a href="index.html"><img src="up.gif" alt="index" border="0"><br>
Index
</a></div>
-<div class="next_link"><a href="tests.html"><img src="next.gif" alt="tests" border="0"><br>
-Tests
+<div class="next_link"><a href="future_work.html"><img src="next.gif" alt="future work" border="0"><br>
+Future work
</a></div><br clear="all" style="clear: all;">
<br clear="all" style="clear: all;">
@@ -62,7 +62,7 @@
The <a href="http://c2.com/cgi/wiki?CompositePattern"><i>composite
design pattern</i></a> revolves about the idea that a tree data structure
can be easily constructed and manipulated by defining the tree node type
-polymorphically so that either is leaf node or else contains a list of
+polymorphically so that either is a leaf node or else contains a list of
pointers to their child nodes.
This way, a tree is the exact same entity as its root node, which allows
for very simple recursive tree-handling algorithms. Large composite trees
@@ -198,22 +198,22 @@
<hr>
-<div class="prev_link"><a href="xxx.html"><img src="prev.gif" alt="xxx" border="0"><br>
-<font color="#ff0000">[not linked yet]</font>
+<div class="prev_link"><a href="reference/tracking.html"><img src="prev.gif" alt="tracking policies" border="0"><br>
+Tracking policies
</a></div>
<div class="up_link"><a href="index.html"><img src="up.gif" alt="index" border="0"><br>
Index
</a></div>
-<div class="next_link"><a href="tests.html"><img src="next.gif" alt="tests" border="0"><br>
-Tests
+<div class="next_link"><a href="future_work.html"><img src="next.gif" alt="future work" border="0"><br>
+Future work
</a></div><br clear="all" style="clear: all;">
<br clear="all" style="clear: all;">
<br>
-<p>Revised November 29th 2007</p>
+<p>Revised January 16th 2008</p>
-<p>© Copyright 2006-2007 Joaquín M López Muñoz.
+<p>© Copyright 2006-2008 Joaquín M López Muñoz.
Distributed under the Boost Software
License, Version 1.0. (See accompanying file <a href="../../../LICENSE_1_0.txt">
LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
Modified: sandbox/flyweight/libs/flyweight/doc/index.html
==============================================================================
--- sandbox/flyweight/libs/flyweight/doc/index.html (original)
+++ sandbox/flyweight/libs/flyweight/doc/index.html 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -53,9 +53,10 @@
<ul>
<li>Tutorial</li>
<li>Reference</li>
- <li><font color="#ff0000">[more to come]</font></li>
<li>Examples</li>
<li>Tests</li>
+ <li>Future work</li>
+ <li>Review notes</li>
<li>Acknowledgements</li>
</ul>
@@ -69,9 +70,9 @@
<br>
-<p>Revised November 27th 2007</p>
+<p>Revised January 8th 2008</p>
-<p>© Copyright 2006-2007 Joaquín M López Muñoz.
+<p>© Copyright 2006-2008 Joaquín M López Muñoz.
Distributed under the Boost Software
License, Version 1.0. (See accompanying file <a href="../../../LICENSE_1_0.txt">
LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
Modified: sandbox/flyweight/libs/flyweight/doc/reference/locking.html
==============================================================================
--- sandbox/flyweight/libs/flyweight/doc/reference/locking.html (original)
+++ sandbox/flyweight/libs/flyweight/doc/reference/locking.html 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -225,7 +225,7 @@
<a href="#locking"><code>Locking Policy</code></a> that specifies a basic
mutex type based on the simplest synchronization mechanisms provided by
the environment; When no threading capabilities are available,
-<code>no_locking</code> specifies a dummy type without actual
+<code>simple_locking</code> specifies a dummy type without actual
synchronization capabilities.
</p>
@@ -276,9 +276,9 @@
<br>
-<p>Revised September 26th 2007</p>
+<p>Revised January 16th 2008</p>
-<p>© Copyright 2006-2007 Joaquín M López Muñoz.
+<p>© Copyright 2006-2008 Joaquín M López Muñoz.
Distributed under the Boost Software
License, Version 1.0. (See accompanying file <a href="../../../../LICENSE_1_0.txt">
LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
Modified: sandbox/flyweight/libs/flyweight/doc/reference/tracking.html
==============================================================================
--- sandbox/flyweight/libs/flyweight/doc/reference/tracking.html (original)
+++ sandbox/flyweight/libs/flyweight/doc/reference/tracking.html 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -8,7 +8,7 @@
<link rel="start" href="../index.html">
<link rel="prev" href="locking.html">
<link rel="up" href="index.html">
-<link rel="next" href="xxx.html">
+<link rel="next" href="../examples.html">
</head>
<body>
@@ -22,8 +22,8 @@
<div class="up_link"><a href="index.html"><img src="../up.gif" alt="Boost.Flyweight reference" border="0"><br>
Boost.Flyweight reference
</a></div>
-<div class="next_link"><a href="xxx.html"><img src="../next.gif" alt="xxx" border="0"><br>
-<font color="#ff0000">[more to come]</font>
+<div class="next_link"><a href="../examples.html"><img src="../next.gif" alt="examples" border="0"><br>
+Examples
</a></div><br clear="all" style="clear: all;">
<hr>
@@ -272,15 +272,15 @@
<div class="up_link"><a href="index.html"><img src="../up.gif" alt="Boost.Flyweight reference" border="0"><br>
Boost.Flyweight reference
</a></div>
-<div class="next_link"><a href="xxx.html"><img src="../next.gif" alt="xxx" border="0"><br>
-<font color="#ff0000">[more to come]</font>
+<div class="next_link"><a href="../examples.html"><img src="../next.gif" alt="examples" border="0"><br>
+Examples
</a></div><br clear="all" style="clear: all;">
<br>
-<p>Revised September 26th 2007</p>
+<p>Revised January 8th 2008</p>
-<p>© Copyright 2006-2007 Joaquín M López Muñoz.
+<p>© Copyright 2006-2008 Joaquín M López Muñoz.
Distributed under the Boost Software
License, Version 1.0. (See accompanying file <a href="../../../../LICENSE_1_0.txt">
LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
Modified: sandbox/flyweight/libs/flyweight/example/Jamfile.v2
==============================================================================
--- sandbox/flyweight/libs/flyweight/example/Jamfile.v2 (original)
+++ sandbox/flyweight/libs/flyweight/example/Jamfile.v2 2008-01-18 11:32:08 EST (Fri, 18 Jan 2008)
@@ -5,7 +5,7 @@
# (See accompanying file LICENSE_1_0.txt or copy at
# http://www.boost.org/LICENSE_1_0.txt)
#
-# See http://www.boost.org/libs/multi_index for library home page.
+# See http://www.boost.org/libs/flyweight for library home page.
exe basic
: basic.cpp
Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk