Boost logo

Boost-Commit :

From: daniel_james_at_[hidden]
Date: 2008-04-05 08:00:35


Author: danieljames
Date: 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
New Revision: 44049
URL: http://svn.boost.org/trac/boost/changeset/44049

Log:
Merged revisions 43922-44048 via svnmerge from
https://svn.boost.org/svn/boost/branches/unordered/trunk

........
  r43922 | danieljames | 2008-03-29 14:55:59 +0000 (Sat, 29 Mar 2008) | 1 line
  
  Fix some typos in the reference documentation.
........
  r43959 | danieljames | 2008-03-31 18:08:57 +0100 (Mon, 31 Mar 2008) | 1 line
  
  Update svnmerge to latest trunk.
........
  r43962 | danieljames | 2008-03-31 18:29:59 +0100 (Mon, 31 Mar 2008) | 1 line
  
  Add a name variable to the release script, so that I can have different release names in different branches.
........
  r43966 | danieljames | 2008-03-31 18:43:16 +0100 (Mon, 31 Mar 2008) | 1 line
  
  Fix the image directory for standalone docs.
........
  r43971 | danieljames | 2008-03-31 19:17:25 +0100 (Mon, 31 Mar 2008) | 1 line
  
  Fix the unordered stylesheet.
........
  r43981 | danieljames | 2008-04-01 13:31:26 +0100 (Tue, 01 Apr 2008) | 2 lines
  
  Cast the pointer in the Visual C++ 6.5 _Charalloc method.
........
  r43995 | danieljames | 2008-04-02 12:50:27 +0100 (Wed, 02 Apr 2008) | 1 line
  
  Try using the interprocess containers for testing. Compilation is a bit slower but hopefully I'll run into less cross-platform problems.
........
  r43996 | danieljames | 2008-04-02 13:25:49 +0100 (Wed, 02 Apr 2008) | 1 line
  
  Revert my experiment with the interprocess containers. It didn't work out.
........
  r44042 | danieljames | 2008-04-04 20:38:09 +0100 (Fri, 04 Apr 2008) | 1 line
  
  Make hash table data a member of hash table, instead of a base.
........
  r44046 | danieljames | 2008-04-05 12:38:05 +0100 (Sat, 05 Apr 2008) | 1 line
  
  Remove rvalue_ref from Jamfile.v2 - I didn't mean to check it in.
........
  r44047 | danieljames | 2008-04-05 12:39:38 +0100 (Sat, 05 Apr 2008) | 1 line
  
  New constructors with allocators.
........
  r44048 | danieljames | 2008-04-05 12:58:11 +0100 (Sat, 05 Apr 2008) | 1 line
  
  Document the new constructors.
........

Properties modified:
   branches/unordered/dev/ (props changed)
Text files modified:
   branches/unordered/dev/boost/unordered/detail/hash_table_impl.hpp | 157 ++++++++++++++++++++---------------
   branches/unordered/dev/boost/unordered_map.hpp | 79 +++++++++++------
   branches/unordered/dev/boost/unordered_set.hpp | 80 +++++++++++------
   branches/unordered/dev/libs/functional/hash/doc/Jamfile.v2 | 6
   branches/unordered/dev/libs/unordered/doc/Jamfile.v2 | 4
   branches/unordered/dev/libs/unordered/doc/ref.xml | 176 +++++++++++++++++++++++++--------------
   branches/unordered/dev/libs/unordered/test/exception/constructor_exception_tests.cpp | 10 ++
   branches/unordered/dev/libs/unordered/test/exception/copy_exception_tests.cpp | 16 +++
   branches/unordered/dev/libs/unordered/test/helpers/allocator.hpp | 2
   branches/unordered/dev/libs/unordered/test/unordered/Jamfile.v2 | 2
   branches/unordered/dev/libs/unordered/test/unordered/constructor_tests.cpp | 11 ++
   branches/unordered/dev/libs/unordered/test/unordered/copy_tests.cpp | 24 +++++
   branches/unordered/dev/release.sh | 15 ++-
   13 files changed, 380 insertions(+), 202 deletions(-)

Modified: branches/unordered/dev/boost/unordered/detail/hash_table_impl.hpp
==============================================================================
--- branches/unordered/dev/boost/unordered/detail/hash_table_impl.hpp (original)
+++ branches/unordered/dev/boost/unordered/detail/hash_table_impl.hpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -951,7 +951,6 @@
             typename Hash, typename Pred,
             typename Alloc>
         class BOOST_UNORDERED_TABLE
- : public BOOST_UNORDERED_TABLE_DATA<Alloc>
         {
             typedef BOOST_UNORDERED_TABLE_DATA<Alloc> data;
 
@@ -1014,6 +1013,8 @@
 
         public:
 
+ data data_;
+
             // Constructors
             //
             // In the constructors, if anything throws an exception,
@@ -1022,11 +1023,11 @@
             BOOST_UNORDERED_TABLE(size_type n,
                     hasher const& hf, key_equal const& eq,
                     value_allocator const& a)
- : data(n, a), // throws, cleans itself up
- func1_(hf, eq), // throws " "
- func2_(hf, eq), // throws " "
+ : func1_(hf, eq), // throws, cleans itself up
+ func2_(hf, eq), // throws, cleans itself up
                 func_(&BOOST_UNORDERED_TABLE::func1_), // no throw
- mlf_(1.0f) // no throw
+ mlf_(1.0f), // no throw
+ data_(n, a) // throws, cleans itself up
             {
                 calculate_max_load(); // no throw
             }
@@ -1068,31 +1069,49 @@
             BOOST_UNORDERED_TABLE(I i, I j, size_type n,
                     hasher const& hf, key_equal const& eq,
                     value_allocator const& a)
- : data(initial_size(i, j, n), a), // throws, cleans itself up
- func1_(hf, eq), // throws " "
- func2_(hf, eq), // throws " "
+ : func1_(hf, eq), // throws, cleans itself up
+ func2_(hf, eq), // throws, cleans itself up
                     func_(&BOOST_UNORDERED_TABLE::func1_), // no throw
- mlf_(1.0f) // no throw
+ mlf_(1.0f), // no throw
+ data_(initial_size(i, j, n), a) // throws, cleans itself up
             {
                 calculate_max_load(); // no throw
 
                 // This can throw, but BOOST_UNORDERED_TABLE_DATA's destructor will clean up.
                 insert(i, j);
             }
+
             // Copy Construct
 
             BOOST_UNORDERED_TABLE(BOOST_UNORDERED_TABLE const& x)
- : data(x, x.min_buckets_for_size(x.size())), // throws
- func1_(x.current_functions()), // throws
+ : func1_(x.current_functions()), // throws
                 func2_(x.current_functions()), // throws
                 func_(&BOOST_UNORDERED_TABLE::func1_), // no throw
- mlf_(x.mlf_) // no throw
+ mlf_(x.mlf_), // no throw
+ data_(x.data_, x.min_buckets_for_size(x.size())) // throws
+ {
+ calculate_max_load(); // no throw
+
+ // This can throw, but BOOST_UNORDERED_TABLE_DATA's destructor will clean
+ // up.
+ copy_buckets(x.data_, data_, current_functions());
+ }
+
+ // Copy Construct with allocator
+
+ BOOST_UNORDERED_TABLE(BOOST_UNORDERED_TABLE const& x,
+ value_allocator const& a)
+ : func1_(x.current_functions()), // throws
+ func2_(x.current_functions()), // throws
+ func_(&BOOST_UNORDERED_TABLE::func1_), // no throw
+ mlf_(x.mlf_), // no throw
+ data_(x.min_buckets_for_size(x.size()), a)
             {
                 calculate_max_load(); // no throw
 
                 // This can throw, but BOOST_UNORDERED_TABLE_DATA's destructor will clean
                 // up.
- copy_buckets(x, *this, current_functions());
+ copy_buckets(x.data_, data_, current_functions());
             }
 
             // Assign
@@ -1106,12 +1125,12 @@
             {
                 if(this != &x)
                 {
- this->clear(); // no throw
+ data_.clear(); // no throw
                     func_ = copy_functions(x); // throws, strong
                     mlf_ = x.mlf_; // no throw
                     calculate_max_load(); // no throw
                     reserve(x.size()); // throws
- copy_buckets(x, *this, current_functions()); // throws
+ copy_buckets(x.data_, data_, current_functions()); // throws
                 }
 
                 return *this;
@@ -1138,22 +1157,22 @@
                 functions_ptr new_func_this = copy_functions(x); // throws
                 functions_ptr new_func_that = x.copy_functions(*this); // throws
 
- if(this->allocators_ == x.allocators_) {
- this->data::swap(x); // no throw
+ if(data_.allocators_ == x.data_.allocators_) {
+ data_.swap(x.data_); // no throw
                 }
                 else {
                     // Create new buckets in separate HASH_TABLE_DATA objects
                     // which will clean up if anything throws an exception.
                     // (all can throw, but with no effect as these are new objects).
- data new_this(*this, x.min_buckets_for_size(x.size_));
- copy_buckets(x, new_this, this->*new_func_this);
+ data new_this(data_, x.min_buckets_for_size(x.data_.size_));
+ copy_buckets(x.data_, new_this, this->*new_func_this);
 
- data new_that(x, min_buckets_for_size(this->size_));
- x.copy_buckets(*this, new_that, x.*new_func_that);
+ data new_that(x.data_, min_buckets_for_size(data_.size_));
+ x.copy_buckets(data_, new_that, x.*new_func_that);
 
                     // Start updating the data here, no throw from now on.
- this->data::swap(new_this);
- x.data::swap(new_that);
+ data_.swap(new_this);
+ x.data_.swap(new_that);
                 }
 
                 // We've made it, the rest is no throw.
@@ -1196,7 +1215,7 @@
             // no throw
             value_allocator get_allocator() const
             {
- return this->allocators_.value_alloc_;
+ return data_.allocators_.value_alloc_;
             }
 
             // no throw
@@ -1214,13 +1233,13 @@
             // no throw
             size_type size() const
             {
- return this->size_;
+ return data_.size_;
             }
 
             // no throw
             bool empty() const
             {
- return this->size_ == 0;
+ return data_.size_ == 0;
             }
 
             // no throw
@@ -1237,27 +1256,27 @@
             size_type bucket(key_type const& k) const
             {
                 // hash_function can throw:
- return hash_function()(k) % this->bucket_count_;
+ return hash_function()(k) % data_.bucket_count_;
             }
 
 
             // strong safety
             bucket_ptr get_bucket(key_type const& k) const
             {
- return this->buckets_ + static_cast<difference_type>(bucket(k));
+ return data_.buckets_ + static_cast<difference_type>(bucket(k));
             }
 
             // no throw
             size_type bucket_count() const
             {
- return this->bucket_count_;
+ return data_.bucket_count_;
             }
 
             // no throw
             size_type max_bucket_count() const
             {
                 // -1 to account for the end marker.
- return prev_prime(this->allocators_.bucket_alloc_.max_size() - 1);
+ return prev_prime(data_.allocators_.bucket_alloc_.max_size() - 1);
             }
 
         private:
@@ -1286,7 +1305,7 @@
                 // From 6.3.1/13:
                 // Only resize when size >= mlf_ * count
                 max_load_ = double_to_size_t(ceil(
- (double) mlf_ * this->bucket_count_));
+ (double) mlf_ * data_.bucket_count_));
             }
 
             // basic exception safety
@@ -1338,9 +1357,9 @@
             // no throw
             float load_factor() const
             {
- BOOST_ASSERT(this->bucket_count_ != 0);
- return static_cast<float>(this->size_)
- / static_cast<float>(this->bucket_count_);
+ BOOST_ASSERT(data_.bucket_count_ != 0);
+ return static_cast<float>(data_.size_)
+ / static_cast<float>(data_.bucket_count_);
             }
 
         private:
@@ -1393,10 +1412,10 @@
                 if (n == bucket_count()) // no throw
                     return;
 
- data new_buckets(*this, n); // throws, seperate
- move_buckets(*this, new_buckets, hash_function());
+ data new_buckets(data_, n); // throws, seperate
+ move_buckets(data_, new_buckets, hash_function());
                                                         // basic/no throw
- new_buckets.swap(*this); // no throw
+ new_buckets.swap(data_); // no throw
                 calculate_max_load(); // no throw
             }
 
@@ -1471,18 +1490,18 @@
             {
                 key_type const& k = extract_key(v);
                 size_type hash_value = hash_function()(k);
- bucket_ptr bucket = this->bucket_from_hash(hash_value);
+ bucket_ptr bucket = data_.bucket_from_hash(hash_value);
                 link_ptr position = find_iterator(bucket, k);
 
                 // Create the node before rehashing in case it throws an
                 // exception (need strong safety in such a case).
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
                 a.construct(v);
 
                 // reserve has basic exception safety if the hash function
                 // throws, strong otherwise.
                 if(reserve(size() + 1))
- bucket = this->bucket_from_hash(hash_value);
+ bucket = data_.bucket_from_hash(hash_value);
 
                 // Nothing after the point can throw.
 
@@ -1491,9 +1510,9 @@
                 // I'm relying on link_ptr not being invalidated by
                 // the rehash here.
                 if(BOOST_UNORDERED_BORLAND_BOOL(position))
- this->link_node(n, position);
+ data_.link_node(n, position);
                 else
- this->link_node_in_bucket(n, bucket);
+ data_.link_node_in_bucket(n, bucket);
 
                 return iterator_base(bucket, n);
             }
@@ -1505,7 +1524,7 @@
             iterator_base insert(iterator_base const& it, value_type const& v)
             {
                 // equal can throw, but with no effects
- if (it == this->end() || !equal(extract_key(v), *it)) {
+ if (it == data_.end() || !equal(extract_key(v), *it)) {
                     // Use the standard insert if the iterator doesn't point
                     // to a matching key.
                     return insert(v);
@@ -1515,12 +1534,12 @@
                     // will be inserted at the end of the group.
 
                     link_ptr start(it.node_);
- while(this->prev_in_group(start)->next_ == start)
- start = this->prev_in_group(start);
+ while(data_.prev_in_group(start)->next_ == start)
+ start = data_.prev_in_group(start);
 
                     // Create the node before rehashing in case it throws an
                     // exception (need strong safety in such a case).
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
                     a.construct(v);
 
                     // reserve has basic exception safety if the hash function
@@ -1531,7 +1550,7 @@
                     // Nothing after this point can throw
 
                     link_ptr n = a.release();
- this->link_node(n, start);
+ data_.link_node(n, start);
 
                     return iterator_base(base, n);
                 }
@@ -1553,7 +1572,7 @@
                 else {
                     // Only require basic exception safety here
                     reserve_extra(size() + distance);
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
 
                     for (; i != j; ++i) {
                         a.construct(*i);
@@ -1563,9 +1582,9 @@
                         link_ptr position = find_iterator(bucket, k);
 
                         if(BOOST_UNORDERED_BORLAND_BOOL(position))
- this->link_node(a.release(), position);
+ data_.link_node(a.release(), position);
                         else
- this->link_node_in_bucket(a.release(), bucket);
+ data_.link_node_in_bucket(a.release(), bucket);
                     }
                 }
             }
@@ -1602,7 +1621,7 @@
                 typedef BOOST_DEDUCED_TYPENAME value_type::second_type mapped_type;
 
                 size_type hash_value = hash_function()(k);
- bucket_ptr bucket = this->bucket_from_hash(hash_value);
+ bucket_ptr bucket = data_.bucket_from_hash(hash_value);
                 link_ptr pos = find_iterator(bucket, k);
 
                 if (BOOST_UNORDERED_BORLAND_BOOL(pos))
@@ -1613,18 +1632,18 @@
 
                     // Create the node before rehashing in case it throws an
                     // exception (need strong safety in such a case).
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
                     a.construct(value_type(k, mapped_type()));
 
                     // reserve has basic exception safety if the hash function
                     // throws, strong otherwise.
                     if(reserve(size() + 1))
- bucket = this->bucket_from_hash(hash_value);
+ bucket = data_.bucket_from_hash(hash_value);
 
                     // Nothing after this point can throw.
 
                     link_ptr n = a.release();
- this->link_node_in_bucket(n, bucket);
+ data_.link_node_in_bucket(n, bucket);
 
                     return data::get_value(n);
                 }
@@ -1639,7 +1658,7 @@
                 // No side effects in this initial code
                 key_type const& k = extract_key(v);
                 size_type hash_value = hash_function()(k);
- bucket_ptr bucket = this->bucket_from_hash(hash_value);
+ bucket_ptr bucket = data_.bucket_from_hash(hash_value);
                 link_ptr pos = find_iterator(bucket, k);
                 
                 if (BOOST_UNORDERED_BORLAND_BOOL(pos)) {
@@ -1653,18 +1672,18 @@
 
                     // Create the node before rehashing in case it throws an
                     // exception (need strong safety in such a case).
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
                     a.construct(v);
 
                     // reserve has basic exception safety if the hash function
                     // throws, strong otherwise.
                     if(reserve(size() + 1))
- bucket = this->bucket_from_hash(hash_value);
+ bucket = data_.bucket_from_hash(hash_value);
 
                     // Nothing after this point can throw.
 
                     link_ptr n = a.release();
- this->link_node_in_bucket(n, bucket);
+ data_.link_node_in_bucket(n, bucket);
 
                     return std::pair<iterator_base, bool>(
                         iterator_base(bucket, n), true);
@@ -1677,7 +1696,7 @@
             // strong otherwise
             iterator_base insert(iterator_base const& it, value_type const& v)
             {
- if(it != this->end() && equal(extract_key(v), *it))
+ if(it != data_.end() && equal(extract_key(v), *it))
                     return it;
                 else
                     return insert(v).first;
@@ -1710,12 +1729,12 @@
             template <typename InputIterator>
             void insert(InputIterator i, InputIterator j)
             {
- node_constructor a(this->allocators_);
+ node_constructor a(data_.allocators_);
 
                 for (; i != j; ++i) {
                     // No side effects in this initial code
                     size_type hash_value = hash_function()(extract_key(*i));
- bucket_ptr bucket = this->bucket_from_hash(hash_value);
+ bucket_ptr bucket = data_.bucket_from_hash(hash_value);
                     link_ptr pos = find_iterator(bucket, extract_key(*i));
                     
                     if (!BOOST_UNORDERED_BORLAND_BOOL(pos)) {
@@ -1730,11 +1749,11 @@
                         // throws, strong otherwise.
                         if(size() + 1 >= max_load_) {
                             reserve(size() + insert_size(i, j));
- bucket = this->bucket_from_hash(hash_value);
+ bucket = data_.bucket_from_hash(hash_value);
                         }
 
                         // Nothing after this point can throw.
- this->link_node_in_bucket(a.release(), bucket);
+ data_.link_node_in_bucket(a.release(), bucket);
                     }
                 }
             }
@@ -1746,7 +1765,7 @@
             // no throw
             iterator_base erase(iterator_base const& r)
             {
- return this->data::erase(r);
+ return data_.data::erase(r);
             }
 
             // strong exception safety
@@ -1757,13 +1776,13 @@
                 link_ptr* it = find_for_erase(bucket, k);
 
                 // No throw.
- return *it ? this->erase_group(it, bucket) : 0;
+ return *it ? data_.erase_group(it, bucket) : 0;
             }
 
             // no throw
             iterator_base erase(iterator_base const& r1, iterator_base const& r2)
             {
- return this->data::erase(r1, r2);
+ return data_.data::erase(r1, r2);
             }
 
             // count
@@ -1786,7 +1805,7 @@
                 if (BOOST_UNORDERED_BORLAND_BOOL(it))
                     return iterator_base(bucket, it);
                 else
- return this->end();
+ return data_.end();
             }
 
             value_type& at(key_type const& k) const
@@ -1815,7 +1834,7 @@
                 }
                 else {
                     return std::pair<iterator_base, iterator_base>(
- this->end(), this->end());
+ data_.end(), data_.end());
                 }
             }
 
@@ -1930,7 +1949,7 @@
             link_ptr find_iterator(bucket_ptr bucket,
                     key_type const& k) const
             {
- link_ptr it = this->begin(bucket);
+ link_ptr it = data_.begin(bucket);
                 while (BOOST_UNORDERED_BORLAND_BOOL(it) && !equal(k, data::get_value(it)))
                     it = data::next_group(it);
 

Modified: branches/unordered/dev/boost/unordered_map.hpp
==============================================================================
--- branches/unordered/dev/boost/unordered_map.hpp (original)
+++ branches/unordered/dev/boost/unordered_map.hpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -71,6 +71,18 @@
         {
         }
 
+ // TODO: Should this be explicit?
+ unordered_map(allocator_type const& a)
+ : base(boost::unordered_detail::default_initial_bucket_count,
+ hasher(), key_equal(), a)
+ {
+ }
+
+ unordered_map(unordered_map const& other, allocator_type const& a)
+ : base(other.base, a)
+ {
+ }
+
         template <class InputIterator>
         unordered_map(InputIterator f, InputIterator l)
             : base(f, l, boost::unordered_detail::default_initial_bucket_count,
@@ -124,32 +136,32 @@
 
         iterator begin()
         {
- return iterator(base.begin());
+ return iterator(base.data_.begin());
         }
 
         const_iterator begin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         iterator end()
         {
- return iterator(base.end());
+ return iterator(base.data_.end());
         }
 
         const_iterator end() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         const_iterator cbegin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         const_iterator cend() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         // modifiers
@@ -188,7 +200,7 @@
 
         void clear()
         {
- base.clear();
+ base.data_.clear();
         }
 
         void swap(unordered_map& other)
@@ -268,7 +280,7 @@
 
         size_type bucket_size(size_type n) const
         {
- return base.bucket_size(n);
+ return base.data_.bucket_size(n);
         }
 
         size_type bucket(const key_type& k) const
@@ -278,32 +290,32 @@
 
         local_iterator begin(size_type n)
         {
- return local_iterator(base.begin(n));
+ return local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator begin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         local_iterator end(size_type n)
         {
- return local_iterator(base.end(n));
+ return local_iterator(base.data_.end(n));
         }
 
         const_local_iterator end(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         const_local_iterator cbegin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator cend(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         // hash policy
@@ -399,6 +411,17 @@
         {
         }
 
+ unordered_multimap(allocator_type const& a)
+ : base(boost::unordered_detail::default_initial_bucket_count,
+ hasher(), key_equal(), a)
+ {
+ }
+
+ unordered_multimap(unordered_multimap const& other, allocator_type const& a)
+ : base(other.base, a)
+ {
+ }
+
         template <class InputIterator>
         unordered_multimap(InputIterator f, InputIterator l)
             : base(f, l, boost::unordered_detail::default_initial_bucket_count,
@@ -452,32 +475,32 @@
 
         iterator begin()
         {
- return iterator(base.begin());
+ return iterator(base.data_.begin());
         }
 
         const_iterator begin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         iterator end()
         {
- return iterator(base.end());
+ return iterator(base.data_.end());
         }
 
         const_iterator end() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         const_iterator cbegin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         const_iterator cend() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         // modifiers
@@ -515,7 +538,7 @@
 
         void clear()
         {
- base.clear();
+ base.data_.clear();
         }
 
         void swap(unordered_multimap& other)
@@ -580,7 +603,7 @@
 
         size_type bucket_size(size_type n) const
         {
- return base.bucket_size(n);
+ return base.data_.bucket_size(n);
         }
 
         size_type bucket(const key_type& k) const
@@ -590,32 +613,32 @@
 
         local_iterator begin(size_type n)
         {
- return local_iterator(base.begin(n));
+ return local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator begin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         local_iterator end(size_type n)
         {
- return local_iterator(base.end(n));
+ return local_iterator(base.data_.end(n));
         }
 
         const_local_iterator end(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         const_local_iterator cbegin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator cend(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         // hash policy

Modified: branches/unordered/dev/boost/unordered_set.hpp
==============================================================================
--- branches/unordered/dev/boost/unordered_set.hpp (original)
+++ branches/unordered/dev/boost/unordered_set.hpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -69,6 +69,18 @@
         {
         }
 
+ // TODO: Should this be explicit?
+ unordered_set(allocator_type const& a)
+ : base(boost::unordered_detail::default_initial_bucket_count,
+ hasher(), key_equal(), a)
+ {
+ }
+
+ unordered_set(unordered_set const& other, allocator_type const& a)
+ : base(other.base, a)
+ {
+ }
+
         template <class InputIterator>
         unordered_set(InputIterator f, InputIterator l)
             : base(f, l, boost::unordered_detail::default_initial_bucket_count,
@@ -121,32 +133,32 @@
 
         iterator begin()
         {
- return iterator(base.begin());
+ return iterator(base.data_.begin());
         }
 
         const_iterator begin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         iterator end()
         {
- return iterator(base.end());
+ return iterator(base.data_.end());
         }
 
         const_iterator end() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         const_iterator cbegin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         const_iterator cend() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         // modifiers
@@ -185,7 +197,7 @@
 
         void clear()
         {
- base.clear();
+ base.data_.clear();
         }
 
         void swap(unordered_set& other)
@@ -238,7 +250,7 @@
 
         size_type bucket_size(size_type n) const
         {
- return base.bucket_size(n);
+ return base.data_.bucket_size(n);
         }
 
         size_type bucket(const key_type& k) const
@@ -248,32 +260,32 @@
 
         local_iterator begin(size_type n)
         {
- return local_iterator(base.begin(n));
+ return local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator begin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         local_iterator end(size_type n)
         {
- return local_iterator(base.end(n));
+ return local_iterator(base.data_.end(n));
         }
 
         const_local_iterator end(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         const_local_iterator cbegin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator cend(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         // hash policy
@@ -367,6 +379,18 @@
         {
         }
 
+ // TODO: Should this be explicit?
+ unordered_multiset(allocator_type const& a)
+ : base(boost::unordered_detail::default_initial_bucket_count,
+ hasher(), key_equal(), a)
+ {
+ }
+
+ unordered_multiset(unordered_multiset const& other, allocator_type const& a)
+ : base(other.base, a)
+ {
+ }
+
         template <class InputIterator>
         unordered_multiset(InputIterator f, InputIterator l)
             : base(f, l, boost::unordered_detail::default_initial_bucket_count,
@@ -419,32 +443,32 @@
 
         iterator begin()
         {
- return iterator(base.begin());
+ return iterator(base.data_.begin());
         }
 
         const_iterator begin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         iterator end()
         {
- return iterator(base.end());
+ return iterator(base.data_.end());
         }
 
         const_iterator end() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         const_iterator cbegin() const
         {
- return const_iterator(base.begin());
+ return const_iterator(base.data_.begin());
         }
 
         const_iterator cend() const
         {
- return const_iterator(base.end());
+ return const_iterator(base.data_.end());
         }
 
         // modifiers
@@ -482,7 +506,7 @@
 
         void clear()
         {
- base.clear();
+ base.data_.clear();
         }
 
         void swap(unordered_multiset& other)
@@ -535,7 +559,7 @@
 
         size_type bucket_size(size_type n) const
         {
- return base.bucket_size(n);
+ return base.data_.bucket_size(n);
         }
 
         size_type bucket(const key_type& k) const
@@ -545,32 +569,32 @@
 
         local_iterator begin(size_type n)
         {
- return local_iterator(base.begin(n));
+ return local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator begin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         local_iterator end(size_type n)
         {
- return local_iterator(base.end(n));
+ return local_iterator(base.data_.end(n));
         }
 
         const_local_iterator end(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         const_local_iterator cbegin(size_type n) const
         {
- return const_local_iterator(base.begin(n));
+ return const_local_iterator(base.data_.begin(n));
         }
 
         const_local_iterator cend(size_type n) const
         {
- return const_local_iterator(base.end(n));
+ return const_local_iterator(base.data_.end(n));
         }
 
         // hash policy

Modified: branches/unordered/dev/libs/functional/hash/doc/Jamfile.v2
==============================================================================
--- branches/unordered/dev/libs/functional/hash/doc/Jamfile.v2 (original)
+++ branches/unordered/dev/libs/functional/hash/doc/Jamfile.v2 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -5,9 +5,9 @@
 
 xml hash : hash.qbk ;
 boostbook standalone : hash :
- <xsl:param>boost.root=../../../../..
- <xsl:param>boost.libraries=../../../../libraries.htm
- <xsl:param>html.stylesheet=../../../../../doc/html/boostbook.css
+ <xsl:param>admon.graphics.path=images/
+ <xsl:param>navig.graphics.path=images/
+ <xsl:param>html.stylesheet=boostbook.css
     <xsl:param>chunk.first.sections=1
     <xsl:param>chunk.section.depth=2
     <xsl:param>generate.section.toc.level=2

Modified: branches/unordered/dev/libs/unordered/doc/Jamfile.v2
==============================================================================
--- branches/unordered/dev/libs/unordered/doc/Jamfile.v2 (original)
+++ branches/unordered/dev/libs/unordered/doc/Jamfile.v2 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -5,9 +5,11 @@
 
 xml unordered : unordered.qbk ;
 boostbook standalone : unordered :
+ <xsl:param>admon.graphics.path=images/
+ <xsl:param>navig.graphics.path=images/
+ <xsl:param>html.stylesheet=boostbook.css
     <xsl:param>boost.root=../../../..
     <xsl:param>boost.libraries=../../../libraries.htm
- <xsl:param>html.stylesheet=../../../../doc/html/boostbook.css
     <xsl:param>chunk.first.sections=1
     <xsl:param>chunk.section.depth=2
     <xsl:param>generate.section.toc.level=2

Modified: branches/unordered/dev/libs/unordered/doc/ref.xml
==============================================================================
--- branches/unordered/dev/libs/unordered/doc/ref.xml (original)
+++ branches/unordered/dev/libs/unordered/doc/ref.xml 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -2,20 +2,9 @@
 Copyright Daniel James 2006-2008
 Distributed under the Boost Software License, Version 1.0. (See accompanying
 file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
--->
-
- <library-reference>
- <!--
- Header: <boost/unordered_set.hpp>
- -->
-
+--><library-reference>
     <header name="boost/unordered_set.hpp">
       <namespace name="boost">
-
- <!--
- boost::unordered_set
- -->
-
         <class name="unordered_set">
           <template>
             <template-type-parameter name="Value">
@@ -30,10 +19,11 @@
               <default><type>std::allocator&lt;Value&gt;</type></default>
             </template-type-parameter>
           </template>
- <purpose>An unordered associative container that stores unique values.
+ <purpose>
+ An unordered associative container that stores unique values.
           </purpose>
           <description>
- <para>For the normative reference see chapter 23 of
+ <para>For the normative reference see chapter 23 of
               <ulink url="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2461.pdf">the working draft of the C++ standard [n2461].</ulink></para>
             <para><emphasis role="bold">Template Parameters</emphasis>
               <informaltable>
@@ -48,7 +38,7 @@
                     <row>
                       <entry><emphasis>Pred</emphasis></entry>
                       <entry>A binary function object that implements an equivalence relation on values of type <code>Value</code>.
- A binary function object that induces an equivalence relation on values of type Key.
+ A binary function object that induces an equivalence relation on values of type Key.
                         It takes two arguments of type Key and returns a value of type bool.</entry></row>
                     <row>
                       <entry><emphasis>Alloc</emphasis></entry>
@@ -191,6 +181,25 @@
               <para>The copy constructor. Copies the contained elements, hash function, predicate, maximum load factor and allocator.</para>
             </description>
           </constructor>
+ <constructor>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an empty container, using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
+ <constructor>
+ <parameter name="x">
+ <paramtype>unordered_set const&amp;</paramtype>
+ </parameter>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an container, copying <code>x</code>'s contained elements, hash function, predicate, maximum load factor, but using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
           <destructor>
           </destructor>
           <method name="operator=">
@@ -391,7 +400,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>key_equal</code> or <code>hasher</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </method>
@@ -685,17 +694,12 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>Hash</code> or <code>Pred</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </function>
           </free-function-group>
         </class>
-
- <!--
- boost::unordered_multiset
- -->
-
         <class name="unordered_multiset">
           <template>
             <template-type-parameter name="Value">
@@ -710,10 +714,11 @@
               <default><type>std::allocator&lt;Value&gt;</type></default>
             </template-type-parameter>
           </template>
- <purpose>An unordered associative container that stores values. The same key can be stored multiple times.
+ <purpose>
+ An unordered associative container that stores values. The same key can be stored multiple times.
           </purpose>
           <description>
- <para>For the normative reference see chapter 23 of
+ <para>For the normative reference see chapter 23 of
               <ulink url="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2461.pdf">the working draft of the C++ standard [n2461].</ulink></para>
             <para><emphasis role="bold">Template Parameters</emphasis>
               <informaltable>
@@ -728,7 +733,7 @@
                     <row>
                       <entry><emphasis>Pred</emphasis></entry>
                       <entry>A binary function object that implements an equivalence relation on values of type <code>Value</code>.
- A binary function object that induces an equivalence relation on values of type Key.
+ A binary function object that induces an equivalence relation on values of type Key.
                         It takes two arguments of type Key and returns a value of type bool.</entry></row>
                     <row>
                       <entry><emphasis>Alloc</emphasis></entry>
@@ -871,6 +876,25 @@
               <para>The copy constructor. Copies the contained elements, hash function, predicate, maximum load factor and allocator.</para>
             </description>
           </constructor>
+ <constructor>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an empty container, using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
+ <constructor>
+ <parameter name="x">
+ <paramtype>unordered_multiset const&amp;</paramtype>
+ </parameter>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an container, copying <code>x</code>'s contained elements, hash function, predicate, maximum load factor, but using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
           <destructor>
           </destructor>
           <method name="operator=">
@@ -989,7 +1013,7 @@
               </parameter>
               <type>void</type>
               <description>
- <para>Inserts a range of elements into the container. </para>
+ <para>Inserts a range of elements into the container.</para>
               </description>
               <throws>
                 <para>When inserting a single element, if an exception is thrown by an operation other than a call to <code>hasher</code> the function has no effect.</para>
@@ -1070,7 +1094,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>key_equal</code> or <code>hasher</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </method>
@@ -1364,7 +1388,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>Hash</code> or <code>Pred</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </function>
@@ -1372,17 +1396,8 @@
         </class>
       </namespace>
     </header>
- <!--
- Header: <boost/unordered_map.hpp>
- -->
-
     <header name="boost/unordered_map.hpp">
       <namespace name="boost">
-
- <!--
- boost::unordered_map
- -->
-
         <class name="unordered_map">
           <template>
             <template-type-parameter name="Key">
@@ -1390,19 +1405,20 @@
             <template-type-parameter name="Mapped">
             </template-type-parameter>
             <template-type-parameter name="Hash">
- <default><type>boost::hash&lt;Value&gt;</type></default>
+ <default><type>boost::hash&lt;Key&gt;</type></default>
             </template-type-parameter>
             <template-type-parameter name="Pred">
- <default><type>std::equal_to&lt;Value&gt;</type></default>
+ <default><type>std::equal_to&lt;Key&gt;</type></default>
             </template-type-parameter>
             <template-type-parameter name="Alloc">
- <default><type>std::allocator&lt;std::pair&lt;const Key, Mapped&gt; &gt;</type></default>
+ <default><type>std::allocator&lt;std::pair&lt;Key const, Mapped&gt; &gt;</type></default>
             </template-type-parameter>
           </template>
- <purpose>An unordered associative container that associates unique keys with another value.
+ <purpose>
+ An unordered associative container that associates unique keys with another value.
           </purpose>
           <description>
- <para>For the normative reference see chapter 23 of
+ <para>For the normative reference see chapter 23 of
               <ulink url="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2461.pdf">the working draft of the C++ standard [n2461].</ulink></para>
             <para><emphasis role="bold">Template Parameters</emphasis>
               <informaltable>
@@ -1420,7 +1436,7 @@
                     <row>
                       <entry><emphasis>Pred</emphasis></entry>
                       <entry>A binary function object that implements an equivalence relation on values of type <code>Key</code>.
- A binary function object that induces an equivalence relation on values of type Key.
+ A binary function object that induces an equivalence relation on values of type Key.
                         It takes two arguments of type Key and returns a value of type bool.</entry></row>
                     <row>
                       <entry><emphasis>Alloc</emphasis></entry>
@@ -1432,7 +1448,7 @@
             <type>Key</type>
           </typedef>
           <typedef name="value_type">
- <type>std::pair&lt;Key const, Value&gt;</type>
+ <type>std::pair&lt;Key const, Mapped&gt;</type>
           </typedef>
           <typedef name="mapped_type">
             <type>Mapped</type>
@@ -1566,6 +1582,25 @@
               <para>The copy constructor. Copies the contained elements, hash function, predicate, maximum load factor and allocator.</para>
             </description>
           </constructor>
+ <constructor>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an empty container, using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
+ <constructor>
+ <parameter name="x">
+ <paramtype>unordered_map const&amp;</paramtype>
+ </parameter>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an container, copying <code>x</code>'s contained elements, hash function, predicate, maximum load factor, but using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
           <destructor>
           </destructor>
           <method name="operator=">
@@ -1766,7 +1801,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>key_equal</code> or <code>hasher</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </method>
@@ -1861,7 +1896,7 @@
                 <para>An exception object of type <code>std::out_of_range</code> if no such element is present.</para>
               </throws>
               <notes>
- <para>This is not specified in the draft standard, but that is probably an oversight. The issue has been raised in
+ <para>This is not specified in the draft standard, but that is probably an oversight. The issue has been raised in
                   <ulink url="http://groups.google.com/group/comp.std.c++/browse_thread/thread/ab7c22a868fd370b">comp.std.c++</ulink>.</para>
               </notes>
             </overloaded-method>
@@ -2103,17 +2138,12 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>Hash</code> or <code>Pred</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </function>
           </free-function-group>
         </class>
-
- <!--
- boost::unordered_multimap
- -->
-
         <class name="unordered_multimap">
           <template>
             <template-type-parameter name="Key">
@@ -2121,19 +2151,20 @@
             <template-type-parameter name="Mapped">
             </template-type-parameter>
             <template-type-parameter name="Hash">
- <default><type>boost::hash&lt;Value&gt;</type></default>
+ <default><type>boost::hash&lt;Key&gt;</type></default>
             </template-type-parameter>
             <template-type-parameter name="Pred">
- <default><type>std::equal_to&lt;Value&gt;</type></default>
+ <default><type>std::equal_to&lt;Key&gt;</type></default>
             </template-type-parameter>
             <template-type-parameter name="Alloc">
- <default><type>std::allocator&lt;std::pair&lt;const Key, Mapped&gt; &gt;</type></default>
+ <default><type>std::allocator&lt;std::pair&lt;Key const, Mapped&gt; &gt;</type></default>
             </template-type-parameter>
           </template>
- <purpose>An unordered associative container that associates keys with another value. The same key can be stored multiple times.
+ <purpose>
+ An unordered associative container that associates keys with another value. The same key can be stored multiple times.
           </purpose>
           <description>
- <para>For the normative reference see chapter 23 of
+ <para>For the normative reference see chapter 23 of
               <ulink url="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2461.pdf">the working draft of the C++ standard [n2461].</ulink></para>
             <para><emphasis role="bold">Template Parameters</emphasis>
               <informaltable>
@@ -2151,7 +2182,7 @@
                     <row>
                       <entry><emphasis>Pred</emphasis></entry>
                       <entry>A binary function object that implements an equivalence relation on values of type <code>Key</code>.
- A binary function object that induces an equivalence relation on values of type Key.
+ A binary function object that induces an equivalence relation on values of type Key.
                         It takes two arguments of type Key and returns a value of type bool.</entry></row>
                     <row>
                       <entry><emphasis>Alloc</emphasis></entry>
@@ -2163,7 +2194,7 @@
             <type>Key</type>
           </typedef>
           <typedef name="value_type">
- <type>std::pair&lt;Key const, Value&gt;</type>
+ <type>std::pair&lt;Key const, Mapped&gt;</type>
           </typedef>
           <typedef name="mapped_type">
             <type>Mapped</type>
@@ -2297,6 +2328,25 @@
               <para>The copy constructor. Copies the contained elements, hash function, predicate, maximum load factor and allocator.</para>
             </description>
           </constructor>
+ <constructor>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an empty container, using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
+ <constructor>
+ <parameter name="x">
+ <paramtype>unordered_multimap const&amp;</paramtype>
+ </parameter>
+ <parameter name="a">
+ <paramtype>Allocator const&amp;</paramtype>
+ </parameter>
+ <description>
+ <para>Constructs an container, copying <code>x</code>'s contained elements, hash function, predicate, maximum load factor, but using allocator <code>a</code>.</para>
+ </description>
+ </constructor>
           <destructor>
           </destructor>
           <method name="operator=">
@@ -2415,7 +2465,7 @@
               </parameter>
               <type>void</type>
               <description>
- <para>Inserts a range of elements into the container. </para>
+ <para>Inserts a range of elements into the container.</para>
               </description>
               <throws>
                 <para>When inserting a single element, if an exception is thrown by an operation other than a call to <code>hasher</code> the function has no effect.</para>
@@ -2496,7 +2546,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>key_equal</code> or <code>hasher</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </method>
@@ -2798,7 +2848,7 @@
                 <para>If the allocators are equal, doesn't throw an exception unless it is thrown by the copy constructor or copy assignment operator of <code>Hash</code> or <code>Pred</code>.</para>
               </throws>
               <notes>
- <para>For a discussion of the behavior when allocators aren't equal see
+ <para>For a discussion of the behavior when allocators aren't equal see
                   <link linkend="unordered.rationale.swapping_containers_with_unequal_allocators">the implementation details</link>.</para>
               </notes>
             </function>
@@ -2806,4 +2856,4 @@
         </class>
       </namespace>
     </header>
- </library-reference>
+ </library-reference>
\ No newline at end of file

Modified: branches/unordered/dev/libs/unordered/test/exception/constructor_exception_tests.cpp
==============================================================================
--- branches/unordered/dev/libs/unordered/test/exception/constructor_exception_tests.cpp (original)
+++ branches/unordered/dev/libs/unordered/test/exception/constructor_exception_tests.cpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -58,6 +58,14 @@
 };
 
 template <class T>
+struct construct_test6 : public objects, test::exception_base
+{
+ void run() const {
+ T x(allocator);
+ }
+};
+
+template <class T>
 struct range : public test::exception_base
 {
     test::random_values<T> values;
@@ -123,7 +131,7 @@
 };
 
 RUN_EXCEPTION_TESTS(
- (construct_test1)(construct_test2)(construct_test3)(construct_test4)(construct_test5)
+ (construct_test1)(construct_test2)(construct_test3)(construct_test4)(construct_test5)(construct_test6)
     (range_construct_test1)(range_construct_test2)(range_construct_test3)(range_construct_test4)(range_construct_test5)
     (input_range_construct_test),
     CONTAINER_SEQ)

Modified: branches/unordered/dev/libs/unordered/test/exception/copy_exception_tests.cpp
==============================================================================
--- branches/unordered/dev/libs/unordered/test/exception/copy_exception_tests.cpp (original)
+++ branches/unordered/dev/libs/unordered/test/exception/copy_exception_tests.cpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -44,6 +44,20 @@
     }
 };
 
+template <class T>
+struct copy_with_allocator_test : public test::exception_base
+{
+ test::random_values<T> values;
+ T x;
+ test::exception::allocator<test::exception::object> allocator;
+
+ copy_with_allocator_test() : values(100), x(values.begin(), values.end()) {}
+
+ void run() const {
+ T y(x, allocator);
+ }
+};
+
 RUN_EXCEPTION_TESTS(
- (copy_test1)(copy_test2)(copy_test3),
+ (copy_test1)(copy_test2)(copy_test3)(copy_with_allocator_test),
     CONTAINER_SEQ)

Modified: branches/unordered/dev/libs/unordered/test/helpers/allocator.hpp
==============================================================================
--- branches/unordered/dev/libs/unordered/test/helpers/allocator.hpp (original)
+++ branches/unordered/dev/libs/unordered/test/helpers/allocator.hpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -70,7 +70,7 @@
             using namespace std;
             T* ptr = static_cast<T*>(malloc(n * sizeof(char)));
             if(!ptr) throw std::bad_alloc();
- return ptr;
+ return (char*) ptr;
         }
 #endif
     };

Modified: branches/unordered/dev/libs/unordered/test/unordered/Jamfile.v2
==============================================================================
--- branches/unordered/dev/libs/unordered/test/unordered/Jamfile.v2 (original)
+++ branches/unordered/dev/libs/unordered/test/unordered/Jamfile.v2 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -9,7 +9,7 @@
     : requirements
         <toolset>intel-linux:"<cxxflags>-strict_ansi -cxxlib-icc"
         <toolset>gcc:<cxxflags>-Wsign-promo
- <toolset>msvc:<cxxflags>/W4
+ #<toolset>msvc:<cxxflags>/W4
     ;
 
 test-suite unordered

Modified: branches/unordered/dev/libs/unordered/test/unordered/constructor_tests.cpp
==============================================================================
--- branches/unordered/dev/libs/unordered/test/unordered/constructor_tests.cpp (original)
+++ branches/unordered/dev/libs/unordered/test/unordered/constructor_tests.cpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -136,6 +136,17 @@
         test::check_container(x, v);
         test::check_equivalent_keys(x);
     }
+
+ std::cerr<<"Construct 11\n";
+ {
+ test::random_values<T> v(1000, generator);
+ T x(al);
+ BOOST_TEST(x.empty());
+ BOOST_TEST(test::equivalent(x.hash_function(), hf));
+ BOOST_TEST(test::equivalent(x.key_eq(), eq));
+ BOOST_TEST(test::equivalent(x.get_allocator(), al));
+ test::check_equivalent_keys(x);
+ }
 }
 
 template <class T>

Modified: branches/unordered/dev/libs/unordered/test/unordered/copy_tests.cpp
==============================================================================
--- branches/unordered/dev/libs/unordered/test/unordered/copy_tests.cpp (original)
+++ branches/unordered/dev/libs/unordered/test/unordered/copy_tests.cpp 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -70,6 +70,7 @@
     BOOST_DEDUCED_TYPENAME T::hasher hf(1);
     BOOST_DEDUCED_TYPENAME T::key_equal eq(1);
     BOOST_DEDUCED_TYPENAME T::allocator_type al(1);
+ BOOST_DEDUCED_TYPENAME T::allocator_type al2(2);
 
     {
         T x(10000, hf, eq, al);
@@ -83,6 +84,17 @@
     }
 
     {
+ T x(1000, hf, eq, al);
+ T y(x, al2);
+ BOOST_TEST(y.empty());
+ BOOST_TEST(test::equivalent(y.hash_function(), hf));
+ BOOST_TEST(test::equivalent(y.key_eq(), eq));
+ BOOST_TEST(test::equivalent(y.get_allocator(), al2));
+ BOOST_TEST(x.max_load_factor() == y.max_load_factor());
+ test::check_equivalent_keys(y);
+ }
+
+ {
         test::random_values<T> v(1000);
 
         T x(v.begin(), v.end(), 0, hf, eq, al);
@@ -90,6 +102,18 @@
         test::unordered_equivalence_tester<T> equivalent(x);
         equivalent(y);
         test::check_equivalent_keys(y);
+ BOOST_TEST(test::equivalent(y.get_allocator(), al));
+ }
+
+ {
+ test::random_values<T> v(500);
+
+ T x(v.begin(), v.end(), 0, hf, eq, al);
+ T y(x, al2);
+ test::unordered_equivalence_tester<T> equivalent(x);
+ equivalent(y);
+ test::check_equivalent_keys(y);
+ BOOST_TEST(test::equivalent(y.get_allocator(), al2));
     }
 }
 

Modified: branches/unordered/dev/release.sh
==============================================================================
--- branches/unordered/dev/release.sh (original)
+++ branches/unordered/dev/release.sh 2008-04-05 08:00:34 EDT (Sat, 05 Apr 2008)
@@ -1,12 +1,15 @@
 #!/bin/sh
 
+NAME=unordered
 TARBALL_DIR=~/tarballs
-UNORDERED_DST=$TARBALL_DIR/unordered
+UNORDERED_DST=$TARBALL_DIR/$NAME
+TARBALL=$TARBALL_DIR/$NAME.tar.gz
+ZIPFILE=$TARBALL_DIR/$NAME.zip
 
 mkdir -p $TARBALL_DIR
-rm $TARBALL_DIR/unordered.tar.gz
-rm $TARBALL_DIR/unordered.zip
-rm -rf $TARBALL_DIR/unordered
+rm $TARBALL
+rm $ZIPFILE
+rm -rf $UNORDERED_DST
 
 svn export . $UNORDERED_DST
 
@@ -19,8 +22,8 @@
 rm $UNORDERED_DST/release.sh
 
 cd $TARBALL_DIR
-tar -czf unordered.tar.gz unordered
-zip -r unordered.zip unordered
+tar -czf $TARBALL $NAME
+zip -r $ZIPFILE $NAME
 cd -
 
 rm -r $UNORDERED_DST


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk