[Boost-commit] svn:boost r48316 - trunk/tools/build/v2/tools

From: jurko.gospodnetic_at_[hidden]
Date: 2008-08-23 08:17:50

Author: jurko
Date: 2008-08-23 08:17:50 EDT (Sat, 23 Aug 2008)
New Revision: 48316
URL: http://svn.boost.org/trac/boost/changeset/48316

Log:
Cleaned up the generate.jam Boost Build toolset module. Corrected some copy/paste bugs inherited from the virtual-target.jam module.
Text files modified: 
   trunk/tools/build/v2/tools/generate.jam |    20 ++++++++++++--------                    
   1 files changed, 12 insertions(+), 8 deletions(-)

Modified: trunk/tools/build/v2/tools/generate.jam
==============================================================================
--- trunk/tools/build/v2/tools/generate.jam	(original)
+++ trunk/tools/build/v2/tools/generate.jam	2008-08-23 08:17:50 EDT (Sat, 23 Aug 2008)
@@ -5,14 +5,14 @@
 # Declares main target 'generate' used to produce targets by calling a
 # user-provided rule that takes and produces virtual targets.
 
-import targets ;
 import "class" : new ;
-import property ;
 import errors ;
-import regex ;
-import property-set ;
-import project ;
 import feature ;
+import project ;
+import property ;
+import property-set ;
+import targets ;
+import regex ;
 
 
 feature.feature generating-rule : : free ;
@@ -47,9 +47,11 @@
         local rule-name = [ MATCH ^@(.*) : $(gr) ] ;
         if $(rule-name)
         {
-            if $(tag[2])
+            if $(gr[2])
             {
-                errors.error "<tag>@rulename is present but is not the only <tag> feature" ;
+                local target-name = [ full-name ] ;
+                errors.user-error "Multiple <generating-rule> properties"
+                    "encountered for target $(target-name)." ;
             }
 
             result = [ indirect.call $(rule-name) $(self.project) $(name)
@@ -77,8 +79,10 @@
                 targets = $(result) ;
             }
         }
+        # FIXME: the following loop should be doable using sequence.transform or
+        # some similar utility rule.
         local rt ;
-        for t in $(targets)
+        for local t in $(targets)
         {
             rt += [ virtual-target.register $(t) ] ;
         }