Boost logo

Boost-Commit :

Subject: [Boost-commit] svn:boost r48649 - trunk/tools/build/v2/build
From: jurko.gospodnetic_at_[hidden]
Date: 2008-09-07 04:41:11


Author: jurko
Date: 2008-09-07 04:41:10 EDT (Sun, 07 Sep 2008)
New Revision: 48649
URL: http://svn.boost.org/trac/boost/changeset/48649

Log:
Cleaned up how Boost Build's generator selection implementation updates its cached information when a new target type is defined.
Text files modified:
   trunk/tools/build/v2/build/generators.jam | 11 ++++++-----
   trunk/tools/build/v2/build/type.jam | 6 +-----
   2 files changed, 7 insertions(+), 10 deletions(-)

Modified: trunk/tools/build/v2/build/generators.jam
==============================================================================
--- trunk/tools/build/v2/build/generators.jam (original)
+++ trunk/tools/build/v2/build/generators.jam 2008-09-07 04:41:10 EDT (Sun, 07 Sep 2008)
@@ -60,12 +60,13 @@
 
 
 # Updated cached viable source target type information as needed after a new
-# derived target type gets added. This is needed because if a target type is a
-# viable source target type for some generator then all of the target type's
-# derived target types are automatically viable as source target types for the
-# same generator. Does nothing if a non-derived target type is passed to it.
+# target type gets defined. This is needed because if a target type is a viable
+# source target type for some generator then all of the target type's derived
+# target types should automatically be considered as viable source target types
+# for the same generator as well. Does nothing if a non-derived target type is
+# passed to it.
 #
-rule update-viable-source-target-type-cache-with-derived-type ( type )
+rule update-cached-information-with-a-new-type ( type )
 {
     local base-type = [ type.base $(type) ] ;
     if $(base-type)

Modified: trunk/tools/build/v2/build/type.jam
==============================================================================
--- trunk/tools/build/v2/build/type.jam (original)
+++ trunk/tools/build/v2/build/type.jam 2008-09-07 04:41:10 EDT (Sun, 07 Sep 2008)
@@ -80,11 +80,7 @@
         # Adding a new derived type affects generator selection so we need to
         # make the generator selection module update any of its cached
         # information related to a new derived type being defined.
- if $(base-type)
- {
- generators.update-viable-source-target-type-cache-with-derived-type
- $(type) ;
- }
+ generators.update-cached-information-with-a-new-type $(type) ;
     }
 }
 


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk