[Boost-commit] svn:boost r49345 - in trunk/boost: detail dynamic_bitset

Subject: [Boost-commit] svn:boost r49345 - in trunk/boost: detail dynamic_bitset
From: gennaro.prota_at_[hidden]
Date: 2008-10-15 08:33:37

Author: gennaro_prota
Date: 2008-10-15 08:33:37 EDT (Wed, 15 Oct 2008)
New Revision: 49345
URL: http://svn.boost.org/trac/boost/changeset/49345

Log:
dynamic_bitset:
    * removed one of the workarounds for VC++ <= 7.0 (we don't run tests on
      those compilers, anymore, so we don't really know if the library still
      works with them); other such workarounds exist, though: removing them
      involves heavy refactoring and is probably not worth the corresponding
      risk of destabilization; comments have been added about this latter point

    * comment fixes in detail/dynamic_bitset.hpp

Text files modified: 
   trunk/boost/detail/dynamic_bitset.hpp         |     8 ++++----                                
   trunk/boost/dynamic_bitset/dynamic_bitset.hpp |    14 +++++---------                          
   2 files changed, 9 insertions(+), 13 deletions(-)

Modified: trunk/boost/detail/dynamic_bitset.hpp
==============================================================================
--- trunk/boost/detail/dynamic_bitset.hpp	(original)
+++ trunk/boost/detail/dynamic_bitset.hpp	2008-10-15 08:33:37 EDT (Wed, 15 Oct 2008)
@@ -45,19 +45,19 @@
 
     typedef unsigned char byte_type;
 
-    // This two entities
+    // These two entities
     //
     //     enum mode { access_by_bytes, access_by_blocks };
     //     template <mode> struct mode_to_type {};
     //
-    // were removed, since the regression logs (as of 24 Aug 2008) show
-    // that several compilers have troubles with recognizing
+    // were removed, since the regression logs (as of 24 Aug 2008)
+    // showed that several compilers had troubles with recognizing
     //
     //   const mode m = access_by_bytes
     //
     // as a constant expression
     //
-    // *We'll use a bool, instead *.
+    // * So, we'll use bool, instead of enum *.
     //
     template <bool value>
     struct value_to_type

Modified: trunk/boost/dynamic_bitset/dynamic_bitset.hpp
==============================================================================
--- trunk/boost/dynamic_bitset/dynamic_bitset.hpp	(original)
+++ trunk/boost/dynamic_bitset/dynamic_bitset.hpp	2008-10-15 08:33:37 EDT (Wed, 15 Oct 2008)
@@ -43,20 +43,16 @@
 
 namespace boost {
 
-template
-
-#if defined(BOOST_MSVC) && BOOST_WORKAROUND(BOOST_MSVC, <= 1300)  // 1300 == VC++ 7.0
-   // VC++ (up to 7.0) wants the default arguments again
-   <typename Block = unsigned long, typename Allocator = std::allocator<Block> >
-# else
-   <typename Block, typename Allocator>
-# endif
-
+template <typename Block, typename Allocator>
 class dynamic_bitset
 {
   // Portability note: member function templates are defined inside
   // this class definition to avoid problems with VC++. Similarly,
   // with the member functions of nested classes.
+  //
+  // [October 2008: the note above is mostly historical; new versions
+  // of VC++ are likely able to digest a more drinking form of the
+  // code; but changing it now is probably not worth the risks...]
 
   BOOST_STATIC_ASSERT(detail::dynamic_bitset_impl::allowed_block_type<Block>::value);