Boost logo

Boost-Commit :

Subject: [Boost-commit] svn:boost r53581 - sandbox/stm/boost/stm/detail
From: justin_at_[hidden]
Date: 2009-06-02 19:57:14


Author: jgottschlich
Date: 2009-06-02 19:57:13 EDT (Tue, 02 Jun 2009)
New Revision: 53581
URL: http://svn.boost.org/trac/boost/changeset/53581

Log:
Corrected bug that Sebastian found regarding writer txes allowing stalls for reader txes which caused illegal memory references and livelocks.
Text files modified:
   sandbox/stm/boost/stm/detail/transaction_impl.hpp | 17 +++++++++++++++++
   1 files changed, 17 insertions(+), 0 deletions(-)

Modified: sandbox/stm/boost/stm/detail/transaction_impl.hpp
==============================================================================
--- sandbox/stm/boost/stm/detail/transaction_impl.hpp (original)
+++ sandbox/stm/boost/stm/detail/transaction_impl.hpp 2009-06-02 19:57:13 EDT (Tue, 02 Jun 2009)
@@ -2033,6 +2033,23 @@
 
    if (writes() > 3) allow_stall = false;
 
+ //--------------------------------------------------------------------------
+ // FOR THE TIME BEING, DO NOT ALLOW STALLS AT ALL! Stalls somehow cause
+ // Sebastian's account code to break ... we need to investigate why and fix it.
+ //
+ // Until such time, stalling txes for increased concurrency MUST be disabled.
+ //--------------------------------------------------------------------------
+
+ allow_stall = false;
+
+ //--------------------------------------------------------------------------
+ // FOR THE TIME BEING, DO NOT ALLOW STALLS AT ALL! Stalls somehow cause
+ // Sebastian's account code to break ... we need to investigate why and fix it.
+ //
+ // Until such time, stalling txes for increased concurrency MUST be disabled.
+ //--------------------------------------------------------------------------
+
+
    // warm up the cache with this transaction's bloom filter
 #if PERFORMING_WRITE_BLOOM
    bloom_filter &wbloom = this->wbloom();


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk