Boost logo

Boost-Commit :

Subject: [Boost-commit] svn:boost r60824 - in branches/release: boost libs/array/test
From: marshall_at_[hidden]
Date: 2010-03-25 11:32:13


Author: marshall
Date: 2010-03-25 11:32:12 EDT (Thu, 25 Mar 2010)
New Revision: 60824
URL: http://svn.boost.org/trac/boost/changeset/60824

Log:
Merged array changes from trunk to release; Fixes #3893 and #3168
Properties modified:
   branches/release/boost/array.hpp (contents, props changed)
   branches/release/libs/array/test/array0.cpp (contents, props changed)
Text files modified:
   branches/release/boost/array.hpp | 29 +++++++++++++++++++++++++----
   branches/release/libs/array/test/array0.cpp | 2 +-
   2 files changed, 26 insertions(+), 5 deletions(-)

Modified: branches/release/boost/array.hpp
==============================================================================
--- branches/release/boost/array.hpp (original)
+++ branches/release/boost/array.hpp 2010-03-25 11:32:12 EDT (Thu, 25 Mar 2010)
@@ -13,6 +13,10 @@
  * accompanying file LICENSE_1_0.txt or copy at
  * http://www.boost.org/LICENSE_1_0.txt)
  *
+ * 10 Mar 2010 - (mtc) fill method added, matching resolution of the standard library working group.
+ * See <http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#776> or Trac issue #3168
+ * Eventually, we should remove "assign" which is now a synonym for "fill" (Marshall Clow)
+ * 10 Mar 2010 - added workaround for SUNCC and !STLPort [trac #3893] (Marshall Clow)
  * 29 Jan 2004 - c_array() added, BOOST_NO_PRIVATE_IN_AGGREGATE removed (Nico Josuttis)
  * 23 Aug 2002 - fix for Non-MSVC compilers combined with MSVC libraries.
  * 05 Aug 2001 - minor update (Nico Josuttis)
@@ -29,6 +33,8 @@
 #if BOOST_WORKAROUND(BOOST_MSVC, >= 1400)
 # pragma warning(push)
 # pragma warning(disable:4996) // 'std::equal': Function call with parameters that may be unsafe
+# pragma warning(disable:4510) // boost::array<T,N>' : default constructor could not be generated
+# pragma warning(disable:4610) // warning C4610: class 'boost::array<T,N>' can never be instantiated - user defined constructor required
 #endif
 
 #include <cstddef>
@@ -78,6 +84,11 @@
                                       reference, iterator, reference> > reverse_iterator;
         typedef std::reverse_iterator<std::_Ptrit<value_type, difference_type, const_iterator,
                                       const_reference, iterator, reference> > const_reverse_iterator;
+#elif defined(_RWSTD_NO_CLASS_PARTIAL_SPEC)
+ typedef std::reverse_iterator<iterator, std::random_access_iterator_tag,
+ value_type, reference, iterator, difference_type> reverse_iterator;
+ typedef std::reverse_iterator<const_iterator, std::random_access_iterator_tag,
+ value_type, const_reference, const_iterator, difference_type> const_reverse_iterator;
 #else
         // workaround for broken reverse_iterator implementations
         typedef std::reverse_iterator<iterator,T> reverse_iterator;
@@ -158,7 +169,8 @@
         }
 
         // assign one value to all elements
- void assign (const T& value)
+ void assign (const T& value) { fill ( value ); } // A synonym for fill
+ void fill (const T& value)
         {
             std::fill_n(begin(),size(),value);
         }
@@ -166,7 +178,8 @@
         // check range (may be private because it is static)
         static void rangecheck (size_type i) {
             if (i >= size()) {
- throw std::out_of_range("array<>: index out of range");
+ std::out_of_range e("array<>: index out of range");
+ boost::throw_exception(e);
             }
         }
 
@@ -202,6 +215,11 @@
                                       reference, iterator, reference> > reverse_iterator;
         typedef std::reverse_iterator<std::_Ptrit<value_type, difference_type, const_iterator,
                                       const_reference, iterator, reference> > const_reverse_iterator;
+#elif defined(_RWSTD_NO_CLASS_PARTIAL_SPEC)
+ typedef std::reverse_iterator<iterator, std::random_access_iterator_tag,
+ value_type, reference, iterator, difference_type> reverse_iterator;
+ typedef std::reverse_iterator<const_iterator, std::random_access_iterator_tag,
+ value_type, const_reference, const_iterator, difference_type> const_reverse_iterator;
 #else
         // workaround for broken reverse_iterator implementations
         typedef std::reverse_iterator<iterator,T> reverse_iterator;
@@ -276,12 +294,14 @@
         }
 
         // assign one value to all elements
- void assign (const T& ) { }
-
+ void assign (const T& value) { fill ( value ); }
+ void fill (const T& ) {}
+
         // check range (may be private because it is static)
         static reference failed_rangecheck () {
                 std::out_of_range e("attempt to access element of an empty array");
                 boost::throw_exception(e);
+#if defined(BOOST_NO_EXCEPTIONS) || !defined(BOOST_MSVC)
                 //
                 // We need to return something here to keep
                 // some compilers happy: however we will never
@@ -289,6 +309,7 @@
                 //
                 static T placeholder;
                 return placeholder;
+#endif
             }
     };
 #endif

Modified: branches/release/libs/array/test/array0.cpp
==============================================================================
--- branches/release/libs/array/test/array0.cpp (original)
+++ branches/release/libs/array/test/array0.cpp 2010-03-25 11:32:12 EDT (Thu, 25 Mar 2010)
@@ -32,7 +32,7 @@
     test_type test_case = {};
     const boost::array< T, 0 > const_test_case = test_type();
 
- test_case.assign( T() );
+ test_case.fill ( T() );
 
     // front/back and operator[] must compile, but calling them is undefined
     // Likewise, all tests below should evaluate to false, avoiding undefined behaviour


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk