Boost logo

Boost-Commit :

Subject: [Boost-commit] svn:boost r64271 - in sandbox/SOC/2010/bit_masks: . boost/integer boost/integer/detail/bft lib/integer/test/bft_testing
From: bbartmanboost_at_[hidden]
Date: 2010-07-22 16:25:25


Author: bbartman
Date: 2010-07-22 16:25:24 EDT (Thu, 22 Jul 2010)
New Revision: 64271
URL: http://svn.boost.org/trac/boost/changeset/64271

Log:
renamed the metafunction used for getting the reference type for the get functions
Text files modified:
   sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp | 16 ++++++++--------
   sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/reference_builder.hpp | 4 ++--
   sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp | 4 ++--
   sandbox/SOC/2010/bit_masks/notes.txt | 21 ++++++++-------------
   4 files changed, 20 insertions(+), 25 deletions(-)

Modified: sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp 2010-07-22 16:25:24 EDT (Thu, 22 Jul 2010)
@@ -160,9 +160,9 @@
      */
     //@{
     template <typename Name>
- inline typename detail::disable_if_reference_type_by_name<_self,Name>::type
+ inline typename detail::disable_if_proxy_reference_type_by_name<_self,Name>::type
     get() {
- typedef typename detail::disable_if_reference_type_by_name<
+ typedef typename detail::disable_if_proxy_reference_type_by_name<
             _self,
             Name
>::type reference_info;
@@ -171,12 +171,12 @@
 
 
     template <typename Name>
- inline typename detail::disable_if_reference_type_by_name<
+ inline typename detail::disable_if_proxy_reference_type_by_name<
         const _self,
         Name
>::type
     get() const {
- typedef typename detail::disable_if_reference_type_by_name<
+ typedef typename detail::disable_if_proxy_reference_type_by_name<
             const _self,
             Name
>::type reference_info;
@@ -184,12 +184,12 @@
     }
 
     template <std::size_t Index>
- inline typename detail::enable_if_reference_type_by_index<
+ inline typename detail::enable_if_proxy_reference_type_by_index<
         _self,
         Index
>::type
     get() {
- typedef typename detail::enable_if_reference_type_by_index<
+ typedef typename detail::enable_if_proxy_reference_type_by_index<
             _self,
             Index
>::type reference_info;
@@ -197,12 +197,12 @@
     }
 
     template <std::size_t Index>
- inline typename detail::enable_if_reference_type_by_index<
+ inline typename detail::enable_if_proxy_reference_type_by_index<
         const _self,
         Index
>::type
     get() const {
- typedef typename detail::enable_if_reference_type_by_index<
+ typedef typename detail::enable_if_proxy_reference_type_by_index<
             const _self,
             Index
>::type reference_info;

Modified: sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/reference_builder.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/reference_builder.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/reference_builder.hpp 2010-07-22 16:25:24 EDT (Thu, 22 Jul 2010)
@@ -18,7 +18,7 @@
 namespace boost { namespace detail {
 
 template <typename BitfieldTuple, typename Name>
-struct disable_if_reference_type_by_name {
+struct disable_if_proxy_reference_type_by_name {
     // search for the name,
     typedef typename mpl::find_if<
         typename BitfieldTuple::members,
@@ -61,7 +61,7 @@
 
 
 template <typename BitfieldTuple, std::size_t Index>
-struct enable_if_reference_type_by_index {
+struct enable_if_proxy_reference_type_by_index {
     // check to make sure index is valid
     typedef typename mpl::less<
         mpl::size_t<

Modified: sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp (original)
+++ sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp 2010-07-22 16:25:24 EDT (Thu, 22 Jul 2010)
@@ -28,13 +28,13 @@
 
 int main() {
     {
- typedef detail::disable_if_reference_type_by_name<
+ typedef detail::disable_if_proxy_reference_type_by_name<
             const test_tuple_1,
             salmon
>::type ref_t_1;
         std::size_t store_house = 0;
 
- typedef detail::disable_if_reference_type_by_name<
+ typedef detail::disable_if_proxy_reference_type_by_name<
             test_tuple_1,
             salmon
>::type ref_t_2;

Modified: sandbox/SOC/2010/bit_masks/notes.txt
==============================================================================
--- sandbox/SOC/2010/bit_masks/notes.txt (original)
+++ sandbox/SOC/2010/bit_masks/notes.txt 2010-07-22 16:25:24 EDT (Thu, 22 Jul 2010)
@@ -35,11 +35,6 @@
 
 
 10) arg_parse_impl.hpp
- a) Finish the pointer parsing stuff.
- I ) This includes the pointer shifting stuff as well.
- II ) Remove the fake static assertion which deals with
- shifted pointers and actually implement something that works!
-
     b) Implement the specialization for custom members.
         I ) This could be more of a pain, however it seems quite simple
                 after implementing the pointer stuff.
@@ -47,19 +42,12 @@
     c) Add compile-failure test for the mask type not being the same size as
         a pointer.
 
-11) folder: msvc_fixes/
- a) Remove this folder and remove the include from within bitfield_tuple.
 
 12) bitfield_iterator.hpp - Fusion Extension
- A) Add OR remove const functions because fusion may be a non const only
+ A) Add OR remove const functions. Fusion may be a non const only
         thing. Other option is to make a const iterator but that could be more
         complex then I'm willing to deal with at the moment.
  
-13) Things to add to public/user documentation:
- a) Make note of the issue with retrieving a proxy reference type in a
- const scope and how to deal with it if they wish to create their own
- proxy reference type OR if they wish to actually return the proxy
- reference type.
 
 14) bitfield_tuple.hpp
     a) Consider renaming disable_if_reference_type_by_name
@@ -209,6 +197,13 @@
 no particular file yet.
 6) How to make your own custom policy (After I finish the pointer stuff)
 
+
+General Topic
+Make note of the issue with retrieving a proxy reference type in a
+const scope and how to deal with it if they wish to create their own
+proxy reference type OR if they wish to actually return the proxy
+reference type.
+
 --------------------------------------------------------------------------------
 
 


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk