Boost-Commit :

Date view	Thread view	Subject view	Author view

Subject: [Boost-commit] svn:boost r64386 - in sandbox/SOC/2010/bit_masks: . boost/integer boost/integer/bitfield_tuple boost/integer/detail/bft lib/integer/test/bft_testing
From: bbartmanboost_at_[hidden]
Date: 2010-07-27 09:49:32

Author: bbartman
Date: 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
New Revision: 64386
URL: http://svn.boost.org/trac/boost/changeset/64386

Log:
changed name from bit_align to align

Text files modified:
   sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp | 1 -
   sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple/align.hpp | 2 +-
   sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/arg_parse_impl.hpp | 6 +++---
   sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/bitfield_tuple_impl.hpp | 1 -
   sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/name_lookup.hpp | 2 +-
   sandbox/SOC/2010/bit_masks/boost/integer/high_low_bits.hpp | 1 -
   sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/align_test.cpp | 10 +++++-----
   sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_long_long_test.cpp | 2 +-
   sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_test.cpp | 6 +++---
   sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp | 2 +-
   sandbox/SOC/2010/bit_masks/notes.txt | 15 +++++++++++++++
   11 files changed, 30 insertions(+), 18 deletions(-)

Modified: sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -20,7 +20,6 @@
#include <boost/mpl/not.hpp>
#include <boost/utility/enable_if.hpp>
#include <boost/mpl/deref.hpp>
-#include <boost/type_traits.hpp>
#include <boost/mpl/at.hpp>
#include <boost/mpl/less.hpp>
#include <boost/mpl/size.hpp>

Modified: sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple/align.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple/align.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/bitfield_tuple/align.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -15,7 +15,7 @@
* as the as AlignTo specifies relative to the current offset in bits.
*/
template <std::size_t AlignTo>
-struct bit_align;
+struct align;
}} // end boost::bitfields

#endif

Modified: sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/arg_parse_impl.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/arg_parse_impl.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/arg_parse_impl.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -240,21 +240,21 @@

-/* Specialization for bit_align. */
+/* Specialization for align. */
template < std::size_t AlignTo,
             typename StoragePolicy,
             typename FieldVector,
             typename Offset
>
struct bft_arg_parse_impl <
- bitfields::bit_align<
+ bitfields::align<
         AlignTo
>,
     StoragePolicy,
     FieldVector,
     Offset >
{
- typedef bitfields::bit_align<AlignTo> param;
+ typedef bitfields::align<AlignTo> param;
     typedef FieldVector field_vector;
     typedef StoragePolicy storage_policy;

Modified: sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/bitfield_tuple_impl.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/bitfield_tuple_impl.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/bitfield_tuple_impl.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -15,7 +15,6 @@
#include <cstddef>

// Other boost includes.
-#include <boost/type_traits.hpp>
#include <boost/static_assert.hpp>

// implementation header files.

Modified: sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/name_lookup.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/name_lookup.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/detail/bft/name_lookup.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -7,7 +7,7 @@
#define BOOST_BITFIELD_TUPLE_NAME_LOCATER_HPP
#include <boost/integer/detail/bft/bft_element.hpp>
#include <boost/mpl/find_if.hpp>
-#include <boost/type_traits.hpp>
+#include <boost/type_traits/is_same.hpp>

namespace boost { namespace detail {

Modified: sandbox/SOC/2010/bit_masks/boost/integer/high_low_bits.hpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/boost/integer/high_low_bits.hpp (original)
+++ sandbox/SOC/2010/bit_masks/boost/integer/high_low_bits.hpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -8,7 +8,6 @@
#ifndef BOOST_HIGH_LOW_BIT_HPP
#define BOOST_HIGH_LOW_BIT_HPP

-// #include <boost/type_traits.hpp>
#include <boost/integer/detail/high_low_impl.hpp>
#include <boost/integer/integral_mask.hpp>

Modified: sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/align_test.cpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/align_test.cpp (original)
+++ sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/align_test.cpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -27,7 +27,7 @@
             filler<3>,
             member<int, salmon, 16>,
             flag<blue>,
- bit_align<32>
+ bitfields::align<32>
> test_tuple_1;
         test_tuple_1 temp;
         BOOST_ASSERT(( test_tuple_1::bits_used::value == 32 ));
@@ -37,7 +37,7 @@
     {
         typedef bitfield_tuple<
             storage<std::size_t>,
- bit_align<32>
+ bitfields::align<32>
> test_tuple_2;
         test_tuple_2 temp;
         BOOST_ASSERT(( test_tuple_2::bits_used::value == 0 ));
@@ -49,7 +49,7 @@
         typedef bitfield_tuple<
             storage<std::size_t>,
             member<int,red,9>,
- bit_align<8>
+ bitfields::align<8>
> test_tuple_3;
         test_tuple_3 temp;
         BOOST_ASSERT(( test_tuple_3::bits_used::value == 16));
@@ -58,8 +58,8 @@
     // test case calling align 2x times in a row doesn't do anything.
     {
         typedef bitfield_tuple<
- bit_align<32>,
- bit_align<32>,
+ bitfields::align<32>,
+ bitfields::align<32>,
             storage<unsigned int>
> test_tuple_4;
         test_tuple_4 temp;

Modified: sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_long_long_test.cpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_long_long_test.cpp (original)
+++ sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_long_long_test.cpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -18,7 +18,7 @@

typedef bitfield_tuple<
flag<pink>,
- bit_align<64>
+ align<64>
> test_tuple;

Modified: sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_test.cpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_test.cpp (original)
+++ sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/deduced_storage_type_test.cpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -20,17 +20,17 @@

typedef bitfield_tuple<
     flag<green>,
- bit_align<16>
+ align<16>
> test_16;

typedef bitfield_tuple<
     flag<pink>,
- bit_align<8>
+ align<8>
> test_8;

typedef bitfield_tuple<
     flag<red>,
- bit_align<32>
+ align<32>
> test_32;

Modified: sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp
==============================================================================
--- sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp (original)
+++ sandbox/SOC/2010/bit_masks/lib/integer/test/bft_testing/reference_builder_test.cpp 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -23,7 +23,7 @@
     filler<3>,
     member<int, salmon, 16>,
     flag<blue>,
- bit_align<32>
+ align<32>
> test_tuple_1;

int main() {

Modified: sandbox/SOC/2010/bit_masks/notes.txt
==============================================================================
--- sandbox/SOC/2010/bit_masks/notes.txt (original)
+++ sandbox/SOC/2010/bit_masks/notes.txt 2010-07-27 09:49:28 EDT (Tue, 27 Jul 2010)
@@ -1,3 +1,18 @@
+TODO From Email Responses
+--------------------------------------------------------------------------------
+
+1) create element metafunction for returning the return type of a field.
+2) Create a get free function which takes a bitfield_tuple.
+3) Change bit_align to align.
+4) Change filler to padding.
+
+5) Documentation for align -
+"Ensures the offset of the next bit field is divisible by the supplied value."
+
+-> 6) consider renaming member to field or bitfield
+
+
+--------------------------------------------------------------------------------
List of TODO's throughout the bitfield_tuple

1) template_expansion_macros.hpp

Date view	Thread view	Subject view	Author view

Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk