[Boost-commit] svn:boost r75623 - branches/quickbook-dev/tools/quickbook/src

Subject: [Boost-commit] svn:boost r75623 - branches/quickbook-dev/tools/quickbook/src
From: dnljms_at_[hidden]
Date: 2011-11-22 18:48:10

Author: danieljames
Date: 2011-11-22 18:48:09 EST (Tue, 22 Nov 2011)
New Revision: 75623
URL: http://svn.boost.org/trac/boost/changeset/75623

Log:
Quickbook: Replace id/dirname TODO with a new TODO.
Text files modified: 
   branches/quickbook-dev/tools/quickbook/src/doc_info_actions.cpp |     9 ++-------                               
   branches/quickbook-dev/tools/quickbook/src/doc_info_grammar.cpp |     2 --                                      
   branches/quickbook-dev/tools/quickbook/src/id_manager.cpp       |     3 +++                                     
   3 files changed, 5 insertions(+), 9 deletions(-)

Modified: branches/quickbook-dev/tools/quickbook/src/doc_info_actions.cpp
==============================================================================
--- branches/quickbook-dev/tools/quickbook/src/doc_info_actions.cpp	(original)
+++ branches/quickbook-dev/tools/quickbook/src/doc_info_actions.cpp	2011-11-22 18:48:09 EST (Tue, 22 Nov 2011)
@@ -197,14 +197,9 @@
         std::string include_doc_id_, id_;
 
         if (!include_doc_id.empty())
-            include_doc_id_.assign(
-                include_doc_id.get_quickbook().begin(),
-                include_doc_id.get_quickbook().end());
-
+            include_doc_id_ = include_doc_id.get_quickbook();
         if (!id.empty())
-            id_.assign(
-                id.get_quickbook().begin(),
-                id.get_quickbook().end());
+            id_ = id.get_quickbook();
 
         // Quickbook version
 

Modified: branches/quickbook-dev/tools/quickbook/src/doc_info_grammar.cpp
==============================================================================
--- branches/quickbook-dev/tools/quickbook/src/doc_info_grammar.cpp	(original)
+++ branches/quickbook-dev/tools/quickbook/src/doc_info_grammar.cpp	2011-11-22 18:48:09 EST (Tue, 22 Nov 2011)
@@ -213,8 +213,6 @@
 
         // Document Info Attributes
 
-        // TODO: Restrictions on doc_id and doc_dirname?
-
         local.doc_simple = actions.to_value() [*(~cl::eps_p(']') >> local.char_)];
         local.attribute_rules[doc_info_attributes::version] = &local.doc_simple;
         local.attribute_rules[doc_info_attributes::id] = &local.doc_simple;

Modified: branches/quickbook-dev/tools/quickbook/src/id_manager.cpp
==============================================================================
--- branches/quickbook-dev/tools/quickbook/src/id_manager.cpp	(original)
+++ branches/quickbook-dev/tools/quickbook/src/id_manager.cpp	2011-11-22 18:48:09 EST (Tue, 22 Nov 2011)
@@ -21,6 +21,9 @@
 
 namespace quickbook
 {
+    // TODO: This should possibly try to make ids are generated:
+    // http://www.w3.org/TR/REC-xml/#NT-NameStartChar
+
     //
     // Forward declarations
     //