[Boost-commit] svn:boost r75864 - in trunk: boost libs/conversion/test

Subject: [Boost-commit] svn:boost r75864 - in trunk: boost libs/conversion/test
From: antoshkka_at_[hidden]
Date: 2011-12-08 10:29:46

Author: apolukhin
Date: 2011-12-08 10:29:44 EST (Thu, 08 Dec 2011)
New Revision: 75864
URL: http://svn.boost.org/trac/boost/changeset/75864

Log:
Fixes #6186 (lexical_cast compliation error fixed, when wchar_t is a typedef for unsigned short. Test added)
Added:
   trunk/libs/conversion/test/lexical_cast_typedefed_wchar_test.cpp   (contents, props changed)
Text files modified: 
   trunk/boost/lexical_cast.hpp          |    15 +++++++++++++--                         
   trunk/libs/conversion/test/Jamfile.v2 |     7 ++++++-                                 
   2 files changed, 19 insertions(+), 3 deletions(-)

Modified: trunk/boost/lexical_cast.hpp
==============================================================================
--- trunk/boost/lexical_cast.hpp	(original)
+++ trunk/boost/lexical_cast.hpp	2011-12-08 10:29:44 EST (Thu, 08 Dec 2011)
@@ -1093,6 +1093,8 @@
 
     namespace detail // optimized stream wrapper
     {
+        struct type_used_as_workaround_for_typedefed_wchar_ts{};
+
         // String representation of Source has an upper limit.
         template< class CharT // a result of widest_char transformation
                 , class Traits // usually char_traits<CharT>
@@ -1354,6 +1356,8 @@
 
 /************************************ HELPER FUNCTIONS FOR OPERATORS >> ( ... ) ********************************/
         private:
+            bool shr_unsigned(type_used_as_workaround_for_typedefed_wchar_ts /*var*/) {return true;}
+
             template <typename Type>
             bool shr_unsigned(Type& output)
             {
@@ -1480,8 +1484,15 @@
             }
 
 /************************************ OPERATORS >> ( ... ) ********************************/
-        public:
-            bool operator>>(unsigned short& output)             { return shr_unsigned(output); }
+
+            typedef BOOST_DEDUCED_TYPENAME ::boost::mpl::if_c<
+                ::boost::is_same<CharT, unsigned short>::value
+                , type_used_as_workaround_for_typedefed_wchar_ts
+                , unsigned short
+            >::type ushort_ambiguity_workaround;
+
+            public:
+            bool operator>>(ushort_ambiguity_workaround& output){ return shr_unsigned(output); }
             bool operator>>(unsigned int& output)               { return shr_unsigned(output); }
             bool operator>>(unsigned long int& output)          { return shr_unsigned(output); }
             bool operator>>(short& output)                      { return shr_signed(output); }

Modified: trunk/libs/conversion/test/Jamfile.v2
==============================================================================
--- trunk/libs/conversion/test/Jamfile.v2	(original)
+++ trunk/libs/conversion/test/Jamfile.v2	2011-12-08 10:29:44 EST (Thu, 08 Dec 2011)
@@ -14,7 +14,12 @@
 
 # bring in rules for testing
 import testing ;
+import feature ;
 
+feature.feature nowchar : on :
+ composite optional propagated link-incompatible ;
+feature.compose <nowchar>on : <cxxflags>/Zc:wchar_t- ; 
+ 
 test-suite conversion
   : [ run implicit_cast.cpp ]
     [ compile-fail implicit_cast_fail.cpp ]
@@ -30,6 +35,6 @@
     [ run lexical_cast_inf_nan_test.cpp ../../test/build//boost_unit_test_framework/<link>static ]
     [ run lexical_cast_containers_test.cpp ../../test/build//boost_unit_test_framework/<link>static ]
     [ run lexical_cast_empty_input_test.cpp ../../test/build//boost_unit_test_framework/<link>static ]
+    [ run lexical_cast_typedefed_wchar_test.cpp ../../test/build//boost_unit_test_framework/<link>static : : : <toolset>msvc:<nowchar>on : : ]
   ;
-
       

Added: trunk/libs/conversion/test/lexical_cast_typedefed_wchar_test.cpp
==============================================================================
--- (empty file)
+++ trunk/libs/conversion/test/lexical_cast_typedefed_wchar_test.cpp	2011-12-08 10:29:44 EST (Thu, 08 Dec 2011)
@@ -0,0 +1,50 @@
+//  Unit test for boost::lexical_cast.
+//
+//  See http://www.boost.org for most recent version, including documentation.
+//
+//  Copyright Antony Polukhin, 2011.
+//
+//  Distributed under the Boost
+//  Software License, Version 1.0. (See accompanying file
+//  LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt).
+
+#include <boost/config.hpp>
+
+#if defined(__INTEL_COMPILER)
+#pragma warning(disable: 193 383 488 981 1418 1419)
+#elif defined(BOOST_MSVC)
+#pragma warning(disable: 4097 4100 4121 4127 4146 4244 4245 4511 4512 4701 4800)
+#endif
+
+#include <boost/lexical_cast.hpp>
+#include <boost/test/unit_test.hpp>
+
+void test_typedefed_wchar_t();
+
+using namespace boost;
+
+unit_test::test_suite *init_unit_test_suite(int, char *[])
+{
+    unit_test::test_suite *suite =
+        BOOST_TEST_SUITE("lexical_cast unit test for typedefed wchar_t (mainly for MSVC)");
+    suite->add(BOOST_TEST_CASE(&test_typedefed_wchar_t));
+
+    return suite;
+}
+
+
+void test_typedefed_wchar_t()
+{
+#ifdef BOOST_MSVC
+    BOOST_CHECK((boost::is_same<wchar_t, unsigned short>::value));
+#endif
+
+    BOOST_CHECK_EQUAL(lexical_cast<int>(L"1000"), 1000);
+}
+
+
+
+
+
+
+