Boost logo

Boost-Commit :

Subject: [Boost-commit] svn:boost r82747 - in trunk/boost/test: . tools tools/detail tools/old utils utils/basic_cstring
From: gennadiy.rozental_at_[hidden]
Date: 2013-02-06 20:26:14


Author: rogeeff
Date: 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
New Revision: 82747
URL: http://svn.boost.org/trac/boost/changeset/82747

Log:
number of warnings/remarks cleaned up
Text files modified:
   trunk/boost/test/framework.hpp | 6 +++---
   trunk/boost/test/tools/detail/bitwise_manip.hpp | 4 ++--
   trunk/boost/test/tools/floating_point_comparison.hpp | 6 +++---
   trunk/boost/test/tools/fpc_tolerance.hpp | 2 +-
   trunk/boost/test/tools/interface.hpp | 9 ++++++---
   trunk/boost/test/tools/old/impl.hpp | 6 +++---
   trunk/boost/test/utils/basic_cstring/bcs_char_traits.hpp | 8 ++++----
   trunk/boost/test/utils/is_cstring.hpp | 10 +++++-----
   trunk/boost/test/utils/is_forward_iterable.hpp | 12 ++++++------
   9 files changed, 33 insertions(+), 30 deletions(-)

Modified: trunk/boost/test/framework.hpp
==============================================================================
--- trunk/boost/test/framework.hpp (original)
+++ trunk/boost/test/framework.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -92,7 +92,7 @@
 
 BOOST_TEST_DECL test_unit& get( test_unit_id, test_unit_type );
 template<typename UnitType>
-UnitType& get( test_unit_id id )
+inline UnitType& get( test_unit_id id )
 {
     return static_cast<UnitType&>( get( id, static_cast<test_unit_type>(UnitType::type) ) );
 }
@@ -116,13 +116,13 @@
 // ************** framework errors ************** //
 // ************************************************************************** //
 
-struct BOOST_TEST_DECL internal_error : std::runtime_error {
+struct BOOST_TEST_DECL internal_error : public std::runtime_error {
     internal_error( const_string m ) : std::runtime_error( std::string( m.begin(), m.size() ) ) {}
 };
 
 //____________________________________________________________________________//
 
-struct BOOST_TEST_DECL setup_error : std::runtime_error {
+struct BOOST_TEST_DECL setup_error : public std::runtime_error {
     setup_error( const_string m ) : std::runtime_error( std::string( m.begin(), m.size() ) ) {}
 };
 

Modified: trunk/boost/test/tools/detail/bitwise_manip.hpp
==============================================================================
--- trunk/boost/test/tools/detail/bitwise_manip.hpp (original)
+++ trunk/boost/test/tools/detail/bitwise_manip.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -48,7 +48,7 @@
 namespace tt_detail {
 
 template<typename Lhs, typename Rhs, typename E>
-assertion_result
+inline assertion_result
 bitwise_compare(Lhs const& lhs, Rhs const& rhs, E const& expr )
 {
     assertion_result pr( true );
@@ -89,7 +89,7 @@
 //____________________________________________________________________________//
 
 template<typename T1, typename T2, typename T3, typename T4>
-assertion_result
+inline assertion_result
 operator<<(assertion_evaluate_t<assertion::binary_expr<T1,T2,assertion::op::EQ<T3,T4> > > const& ae, bitwise )
 {
     return bitwise_compare( ae.m_e.lhs().value(), ae.m_e.rhs(), ae.m_e );

Modified: trunk/boost/test/tools/floating_point_comparison.hpp
==============================================================================
--- trunk/boost/test/tools/floating_point_comparison.hpp (original)
+++ trunk/boost/test/tools/floating_point_comparison.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -147,7 +147,7 @@
 //____________________________________________________________________________//
 
 template<typename FPT>
-std::ostream& operator<<( std::ostream& out, percent_tolerance_t<FPT> t )
+inline std::ostream& operator<<( std::ostream& out, percent_tolerance_t<FPT> t )
 {
     return out << t.m_value;
 }
@@ -232,7 +232,7 @@
 // ************************************************************************** //
 
 template<typename FPT1, typename FPT2, typename ToleranceType>
-bool
+inline bool
 is_close_to( FPT1 left, FPT2 right, ToleranceType tolerance )
 {
     return fpc::close_at_tolerance<typename fpc::comp_supertype<FPT1,FPT2>::type>( tolerance, FPC_STRONG )( left, right );
@@ -273,7 +273,7 @@
 // ************************************************************************** //
 
 template<typename FPT>
-bool
+inline bool
 is_small( FPT fpv, FPT tolerance )
 {
     return small_with_tolerance<FPT>( tolerance )( fpv );

Modified: trunk/boost/test/tools/fpc_tolerance.hpp
==============================================================================
--- trunk/boost/test/tools/fpc_tolerance.hpp (original)
+++ trunk/boost/test/tools/fpc_tolerance.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -33,7 +33,7 @@
 // ************************************************************************** //
 
 template<typename FPT>
-FPT&
+inline FPT&
 fpc_tolerance()
 {
     static FPT s_value = FPT();

Modified: trunk/boost/test/tools/interface.hpp
==============================================================================
--- trunk/boost/test/tools/interface.hpp (original)
+++ trunk/boost/test/tools/interface.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -12,14 +12,17 @@
 // Description : contains definition for all test tools in test toolbox
 // ***************************************************************************
 
-#ifndef BOOST_TEST_OLD_TOOLBOX_HPP_111712GER
-#define BOOST_TEST_OLD_TOOLBOX_HPP_111712GER
+#ifndef BOOST_TEST_TOOLS_INTERFACE_HPP_111712GER
+#define BOOST_TEST_TOOLS_INTERFACE_HPP_111712GER
 
 // Boost.Test
 #include <boost/test/unit_test_log.hpp>
 #ifdef BOOST_TEST_TOOLS_DEBUGGABLE
 #include <boost/test/debug.hpp>
 #endif
+#ifdef BOOST_NO_CXX11_AUTO_DECLARATIONS
+#include <boost/test/tools/detail/expression_holder.hpp>
+#endif
 
 // Boost
 #include <boost/preprocessor/control/iif.hpp>
@@ -362,4 +365,4 @@
 
 #include <boost/test/detail/enable_warnings.hpp>
 
-#endif // BOOST_TEST_OLD_TOOLBOX_HPP_111712GER
+#endif // BOOST_TEST_TOOLS_INTERFACE_HPP_111712GER

Modified: trunk/boost/test/tools/old/impl.hpp
==============================================================================
--- trunk/boost/test/tools/old/impl.hpp (original)
+++ trunk/boost/test/tools/old/impl.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -101,7 +101,7 @@
 //____________________________________________________________________________//
 
 template <class Left, class Right>
-assertion_result equal_impl( Left const& left, Right const& right )
+inline assertion_result equal_impl( Left const& left, Right const& right )
 {
     return left == right;
 }
@@ -301,7 +301,7 @@
 //____________________________________________________________________________//
 
 template<typename FPT1, typename FPT2, typename ToleranceType>
-assertion_result
+inline assertion_result
 check_is_close( FPT1 left, FPT2 right, ToleranceType tolerance )
 {
     return check_is_close_t()( left, right, tolerance );
@@ -328,7 +328,7 @@
 //____________________________________________________________________________//
 
 template<typename FPT>
-bool
+inline bool
 check_is_small( FPT fpv, FPT tolerance )
 {
     return fpc::is_small( fpv, tolerance );

Modified: trunk/boost/test/utils/basic_cstring/bcs_char_traits.hpp
==============================================================================
--- trunk/boost/test/utils/basic_cstring/bcs_char_traits.hpp (original)
+++ trunk/boost/test/utils/basic_cstring/bcs_char_traits.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -119,11 +119,11 @@
     }
 };
 
-template<> struct bcs_char_traits_impl<char> : char_traits_with_find<char> {};
-template<> struct bcs_char_traits_impl<wchar_t> : char_traits_with_find<wchar_t> {};
+template<> struct bcs_char_traits_impl<char> : public char_traits_with_find<char> {};
+template<> struct bcs_char_traits_impl<wchar_t> : public char_traits_with_find<wchar_t> {};
 #else
-template<> struct bcs_char_traits_impl<char> : std::char_traits<char> {};
-template<> struct bcs_char_traits_impl<wchar_t> : std::char_traits<wchar_t> {};
+template<> struct bcs_char_traits_impl<char> : public std::char_traits<char> {};
+template<> struct bcs_char_traits_impl<wchar_t> : public std::char_traits<wchar_t> {};
 #endif
 
 template<typename CharT>

Modified: trunk/boost/test/utils/is_cstring.hpp
==============================================================================
--- trunk/boost/test/utils/is_cstring.hpp (original)
+++ trunk/boost/test/utils/is_cstring.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -33,21 +33,21 @@
 namespace ut_detail {
 
 template<typename T>
-struct is_cstring_impl : mpl::false_ {};
+struct is_cstring_impl : public mpl::false_ {};
 
 template<typename T>
-struct is_cstring_impl<T const*> : is_cstring_impl<T*> {};
+struct is_cstring_impl<T const*> : public is_cstring_impl<T*> {};
 
 template<>
-struct is_cstring_impl<char*> : mpl::true_ {};
+struct is_cstring_impl<char*> : public mpl::true_ {};
 
 template<>
-struct is_cstring_impl<wchar_t*> : mpl::true_ {};
+struct is_cstring_impl<wchar_t*> : public mpl::true_ {};
 
 } // namespace ut_detail
 
 template<typename T>
-struct is_cstring : ut_detail::is_cstring_impl<typename decay<T>::type> {};
+struct is_cstring : public ut_detail::is_cstring_impl<typename decay<T>::type> {};
 
 } // namespace unit_test
 } // namespace boost

Modified: trunk/boost/test/utils/is_forward_iterable.hpp
==============================================================================
--- trunk/boost/test/utils/is_forward_iterable.hpp (original)
+++ trunk/boost/test/utils/is_forward_iterable.hpp 2013-02-05 04:20:53 EST (Tue, 05 Feb 2013)
@@ -46,26 +46,26 @@
 
 #ifdef BOOST_NO_CXX11_DECLTYPE
 template<typename T>
-struct is_forward_iterable : mpl::false_ {};
+struct is_forward_iterable : public mpl::false_ {};
 
 template<typename T>
-struct is_forward_iterable<T const> : is_forward_iterable<T> {};
+struct is_forward_iterable<T const> : public is_forward_iterable<T> {};
 
 template<typename T>
-struct is_forward_iterable<T&> : is_forward_iterable<T> {};
+struct is_forward_iterable<T&> : public is_forward_iterable<T> {};
 
 template<typename T>
-struct is_forward_iterable<std::vector<T> > : mpl::true_ {};
+struct is_forward_iterable<std::vector<T> > : public mpl::true_ {};
 
 template<typename T>
-struct is_forward_iterable<std::list<T> > : mpl::true_ {};
+struct is_forward_iterable<std::list<T> > : public mpl::true_ {};
 
 #else
 
 namespace ut_detail {
 
 template<typename T>
-struct is_present : mpl::true_ {};
+struct is_present : public mpl::true_ {};
 
 struct is_forward_iterable_impl {
     template<typename T>


Boost-Commit list run by bdawes at acm.org, david.abrahams at rcn.com, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk