Re: [Boost-maint] [boost-maint][concept_check] Pull request

Subject: Re: [Boost-maint] [boost-maint][concept_check] Pull request
From: Ahmed Charles (acharles_at_[hidden])
Date: 2014-02-11 00:47:37

> Subject: Re: [Boost-maint] [boost-maint][concept_check] Pull request
> From: mclow.lists_at_[hidden]
> Date: Mon, 10 Feb 2014 18:47:15 -0800
> CC: boost-maint_at_[hidden]
> To: acharles_at_[hidden]
> 
> 
> On Feb 8, 2014, at 10:21 PM, Ahmed Charles <acharles_at_[hidden]> wrote:
> 
> > https://github.com/boostorg/concept_check/pull/1
> > 
> > It's just removing some left over files that were apparently deleted in master but not in develop years ago. 
> 
> Ahmed —
> 
> I’m confused; because when I browse at:
> 	https://github.com/boostorg/concept_check/
> 
> I see those files in both branches “master” and “develop”.
> Also, looking at the SVN repo, I see those files on both “trunk” and the “release” branch.
> 
> It is quite possible that those files are no longer used; but I think you need to provide more evidence.
> 
> — Marshall

If I go to my local concept_check directory, I get the following (with my change):

/e/acharles/boost/mod/libs/concept_check (develop u+1)
$ git diff --stat master..develop
 include/boost/concept/assert.hpp             |  3 +--
 include/boost/concept/detail/concept_def.hpp | 17 -----------------
 include/boost/concept/requires.hpp           |  8 +-------
 include/boost/concept/usage.hpp              |  8 --------
 4 files changed, 2 insertions(+), 34 deletions(-)

/e/acharles/boost/mod/libs/concept_check (develop u+1)
$ git diff --stat develop~4..develop~
 include/boost/concept/assert.hpp             |  3 +--
 include/boost/concept/detail/concept_def.hpp | 17 -----------------
 include/boost/concept/requires.hpp           |  8 +-------
 include/boost/concept/usage.hpp              |  8 --------
 4 files changed, 2 insertions(+), 34 deletions(-)

/e/acharles/boost/mod/libs/concept_check (develop u+1)
$

This suggests that the only difference between master and develop are the changes done by Stephen Kelly and that the files that I remove as part of the change, don't exist on master currently.

Note: the file names involved are very similar to files that do actually exist on both, so if you are just eye-balling the difference, it's not as obvious. I'd recommend using git diff to compare.