Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.

Subject: Re: [Boost-maint] [dynamic_bitset] Fixes for various tickets.
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2014-02-28 17:48:16

On Feb 25, 2014, at 11:52 PM, Ahmed Charles <acharles_at_[hidden]> wrote:

> https://github.com/boostorg/dynamic_bitset/pull/5
> 
> [second one snipped]
> 
> The first fixes the following tickets: 8344, 9621, 6947, 6164 and 8445

I thought that 8344 was already fixed.

The fix for 9621 looks fine to me. (and shouldn’t need additional tests)

The code for 6947 (move assignments, etc) - does that code work for self-move? Does it need to?
(yes, it’s a pathological case, but …)
Other than that it looks fine.

The code for and tests for 6164 (test and set) look good to me (thought I suspect that the comments on line 615/620/625 of the test are now inaccurate)

The code and tests for 8445 (all) look fine.

Thanks for doing this!

— Marshall