Boost logo

Boost-Maint :

Subject: Re: [Boost-maint] Anyone have an opinion on the Boost.MPL pull requests?
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2018-02-25 18:23:41


AMDG

boost-maint isn't dead!!!

On 02/25/2018 10:50 AM, Marshall Clow via Boost-maint wrote:
> https://github.com/boostorg/mpl/pull/33

-1.
This warning is ridiculous. Suppressing it is
better than working around it. In general,
unnecessary parentheses are perfectly fine
and can make the parsing more obvious. (Actually
I wouldn't be at all surprised if these parentheses
were added to avoid a different warning in the
first place.)

> https://github.com/boostorg/mpl/pull/32

  This seems like a reasonable change to me.
Since the path comes from the user, it may
contain names that happen to be macros, thus
macro expansion is undesirable. (Another solution
would be to move the %(boost-root)s part into
a -I option.)

> https://github.com/boostorg/mpl/pull/26
>

-1.
This mixes up several unrelated changes,
some of which I disagree with:
e.g. compile tests don't need main.

In Christ,
Steven Watanabe


Boost-Maint list run by bdawes at acm dot org