Re: [Boost-testing] Bug in regression.py?

From: Rene Rivera (grafik.list_at_[hidden])
Date: 2005-11-29 10:51:57

Markus Schöpflin wrote:
> Hello all,
> 
> the function update_source() in regression.py currently looks like this:
> 
> def update_source( user, tag, proxy, args, **unused ):
>      if user is not None or os.path.exists( os.path.join( boost_root, 'CVS' 
> ) ):
>          open( timestamp_path, 'w' ).close()
>          log( 'Updating sources from CVS (%s)...' % timestamp() )
>          retry(
>                cvs_update
>              , ( user, tag, args )
>              )
>      else:
>          get_source( user, tag, proxy, args )
> 
> Obviously the first line is supposed to check whether a CVS update can be 
> done. For this to work correctly, I think the 'or' must be changed to an 
> 'and', right?

No. The check should be equivalent to: if there's a CVS user passed in 
*or* if there's a CVS user already encoded in boost-root/CVS/Root file; 
then one can do a CVS update. Perhaps it should be change to 
specifically check for the CVS/Root file instead of just the CVS subdir.

-- 
-- Grafik - Don't Assume Anything
-- Redshift Software, Inc. - http://redshift-software.com
-- rrivera/acm.org - grafik/redshift-software.com
-- 102708583/icq - grafikrobot/aim - Grafik/jabber.org