Re: [Boost-testing] [boost] [thread]Forever sleeping

Subject: Re: [Boost-testing] [boost] [thread]Forever sleeping
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2017-02-27 06:51:28

Le 24/02/2017 à 15:23, Vicente J. Botet Escriba via Boost a écrit :
> Le 24/02/2017 à 13:46, Vicente J. Botet Escriba a écrit :
>> Le 22/02/2017 à 23:39, Niklas Angare via Boost a écrit :
>>> Recent runs of my regression test runner NA-QNX660-x86 leave a lot 
>>> of Boost.Thread test executables stuck in nanosleep, waiting for a 
>>> condition variable, or both.
>>>
>>> Commit 544eda [1] which switched from CLOCK_REALTIME to 
>>> CLOCK_MONOTONIC seems suspicious to me. If the returned timespec is 
>>> ever compared to values based on the CLOCK_REALTIME epoch, such as 
>>> system_clock, the results will be quite undesirable. Are you sure 
>>> the return values of timespec_now() are only ever compared to each 
>>> other and values based on the CLOCK_MONOTONIC epoch?
>>>
>>> [1] 
>>> https://github.com/boostorg/thread/commit/544eda51bdf0c62b2f29dea6fe1cf935ad62580e
>>>
>>>
>>>
>>>
>> I'll rollback it and analyze more deeply the change.
>>
>>
> Done.
>
> https://github.com/boostorg/thread/commit/9bbf9bed80836282263ec0bdea0adf5c1fa3621b 
>
>
> Please, let me know if it works again.
After this commit the regression tests continued to be available.
I'm really sorry if my bug was the cause of then been not refreshed.
If it was the case, our test system would need some improvements.

Best,
Vicente