Re: [Boost-users] g++ warning: comparing floating point with == or != is unsafe

From: David Abrahams (dave_at_[hidden])
Date: 2006-07-29 17:14:51

cybernet_at_[hidden] writes:

> In:
>     /usr/include/boost/test/floating_point_comparison.hpp
>
> inside:
>
>     template<typename FPT> inline FPT safe_fpt_division( FPT f1, FPT f2 ){
>
> the warning is cause by the code:
>
>        // Avoid underflow.
>         if( f1 == static_cast<FPT>(0) || 
>             f2 > static_cast<FPT>(1) && f1 < f2 * 
> (std::numeric_limits<FPT>::min)() )
>             return static_cast<FPT>(0);
>
> Could someone modify the code to allow it to compile without warnings on 
> g++?

Try replacing 

   f1 == static_cast<FPT>(0)

with

   f1

HTH,

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com