Re: [Boost-users] multi-threaded safe circular_buffer

From: Ovanes Markarian (om_boost_at_[hidden])
Date: 2008-06-09 12:24:05

Steven,

please see my question below.

On Mon, Jun 9, 2008 at 6:14 PM, Steven Watanabe <watanabesj_at_[hidden]>
wrote:

> AMDG
> [...]
>
> // assignment operator
> CircularBuffer& operator= (const CircularBuffer& other)
> {
>     CircularBuffer temp(other);

 why do you need this temp, if it is not used further?

>
>     WriteLock w_lock(rw_mutex);
>
>     using std::swap;
>    swap(m_capacity, other.m_capacity);
>    swap(m_buffer, other.m_buffer);
>
>    return *this;
> }
>
> In Christ,
> Steven Watanabe
>  <http://lists.boost.org/mailman/listinfo.cgi/boost-users>

With Kind Regards,
Ovanes