Re: [Boost-users] [GIL] Adding base_channel_type metafunction

Subject: Re: [Boost-users] [GIL] Adding base_channel_type metafunction
From: Christian Henning (chhenning_at_[hidden])
Date: 2010-11-06 14:05:21

Nathan, I found one more error in the patch. We cannot exchange

typedef typename detail::unsigned_integral_max_value< SrcChannelV
>::value_type src_integer_t;
typedef typename detail::unsigned_integral_max_value< DstChannelV
>::value_type dst_integer_t;

with

typedef typename base_channel_type< SrcChannelV >::type src_integer_t;
typedef typename base_channel_type< DstChannelV >::type dst_integer_t;

since unsigned_integral_max_value<...> will upgrade the base_channel_t
to either uint32_t or uintmax_t.

Luckily I caught that error when running gil's unit tests.

Regards,
Christian