Re: [Boost-users] [property_tree][showstopper][1.45] missing include in string_path.hpp

Subject: Re: [Boost-users] [property_tree][showstopper][1.45] missing include in string_path.hpp
From: Sebastian Redl (sebastian.redl_at_[hidden])
Date: 2010-11-11 15:49:39

On 11.11.2010, at 21:38, Eric Niebler wrote:

> On 11/11/2010 9:41 AM, Eric Niebler wrote:
>> On 11/11/2010 9:23 AM, Phil Ratzloff wrote:
>>> I just compiled my project with the 1.45 beta and got the following error:
>>> 	boost_1_45_0_beta1/boost/property_tree/string_path.hpp(202): error C3861: 'assert': identifier not found
>>> 
>>> Build info: VC2010 Release Win32
>>> 
>>> It succeeds in Debug, but not in Release. I didn't encounter this with 1.44. It's a minor issue I can work around. 
>> 
>> Sounds like a simple matter of adding #include <cassert> in the right
>> place. Sebastian, we're going to hold the release for this. Can you
>> please address it ASAP?
> 
> Heck, this one was trivial so I did it myself. Hope nobody takes offense.

Awesome, thanks. I couldn't have done it until sometime tomorrow.

> 
>> And a suggestion for release+1: BOOST_ASSERT is to be preferred over
>> assert in Boost code.
> 
> This one still holds, I think. If BOOST_ASSERT is *always* to be
> preferred over C's assert macro, then we should probably add that to the
> inspection report, right?

That would probably a good idea.

Sebastian