Re: [Boost-users] [boost] Stacktrace library starts review today 14th Dec

Subject: Re: [Boost-users] [boost] Stacktrace library starts review today 14th Dec
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2016-12-17 13:32:52

2016-12-17 20:51 GMT+03:00 Andrey Semashev <andrey.semashev_at_[hidden]>:
<...>
> That said, I'd like to thank Antony for the submission and encourage
> him to continue his work on the library. The library does try to fill
> an important gap.

Thank you for the review!

I'd like to discuss a proposed changes. Thing that I'm worried about:
* replacing class `stacktrace` with vector<void*> will definitely
break the most common use case std::cout << get_stacktrace(); as it's
not a good idea to overload ostream operator for vector of void
pointers
* addr2line and forking is not nice. Is linking with a GPL licensed
code an acceptable alternative?
* removing `basic_stacktrace` will definitely remove all the
possibilities for optimization of caching COM/parsed DWARF. This is a
quick win that later may turn into big troubles.

-- 
Best regards,
Antony Polukhin