Re: [review][fixed_string] FixedString review starts today

From: pbristow_at_[hidden]
Date: 2019-12-05 10:51:33

> -----Original Message-----
> From: Boost-users <boost-users-bounces_at_[hidden]> On Behalf Of Joaquin M
> López Muñoz via Boost-users
> Sent: 24 November 2019 23:00
> To: boost_at_[hidden]; boost-users_at_[hidden]; boost-
> announce_at_[hidden]
> Cc: Joaquin M López Muñoz <joaquinlopezmunoz_at_[hidden]>
> Subject: [Boost-users] [review][fixed_string] FixedString review starts today
> 
> The Boost formal review of Krystian Stasiowski and Vinnie Falco's FixedString library
> starts today November 25 and extends up to December 4.
> 
> Description
> 
> FixedString provides a dynamically resizable string of characters with compile-time
> fixed capacity and contiguous embedded storage in which the characters are placed
> within the string object itself. Its API closely resembles that of std::string.
> 
> Repo and docs
> 
> GitHub repository: https://github.com/18/fixed_string
> Online docs: https://18.github.io/doc/fixed_string
> 
> Review questions
> 
> Here are some questions you might want to answer in your review:
>    - What is your evaluation of the design?

Carefully considered. 

>    - What is your evaluation of the implementation?

The adjective drop-in might mislead?

There was much discussion of name;  I agree that the name fixed_string is *very* misleading. 

I'd much prefer a longer name that mentions *capacity*.

To throw my hat into the bike-shedding arena, can I propose "bounded_capacity_string" or even just "bounded_string".

I put a higher value on constexpr than compatibility with older C++std versions.  If that means that it doesn't work for pre-C++20, too bad.

>    - What is your evaluation of the documentation?

OK, but lacking examples and tutorials sections, and badly lacking a TOC (but bonus marks for an index), or links to sections and to the index.  Loads of scrolling needed!  

>    - What is your evaluation of the potential usefulness of the library?

Valuable.

>    - Did you try to use the library?  With what compiler?  Did you have any problems?

Perfunctory use.  No problems.

>    - How much effort did you put into your evaluation? A glance? A quick reading? In-
> depth study?

Quick reading and followed the civilized discussions.

>    - Are you knowledgeable about the problem domain?

Not specially. 

The Big Thing that I know that arrays without sizes and null-terminated strings are the worse collision of two computer design disasters !  This is further proof, if one needed it.

> And finally, every review should answer this question:
>    - Do you think the library should be accepted as a Boost library?

Although there are some details and wrinkles to iron out, I'd like to see it in Boost to get wider use in anger, so

Yes accept.

Paul A. Bristow