|
Geometry : |
Subject: [ggl] Reviewing GGL against Boost requirements
From: Mateusz Loskot (mateusz)
Date: 2009-04-25 08:24:10
Barend Gehrels wrote:
>
>>
>>> One thing about 80 characters: this guideline in much more easy to
>>> follow when namespaces are not indented. It's the case in a lot of
>>> Boost code and it's quite accepted in the C++ community. So given the
>>> number of nested namespaces we sometimes have in GGL we could do that
>>> as well. I've never noticed any particular problem of readability in
>>> code I've written that way.
>>
>> So, we're going to not to indent code on namespace level, right?
>
> OK.
>
>> namespace a {
>>
>> class T
>> {
>> public:
>> void foo();
>> protected:
>> void bar();
>> private:
>> std::size_t count_;
>> };
>>
>> } // namespace a
>
> Few things about this:
> - I prefer a struct above a class because, especially in templates, many
> is public, often there is no protected / private at all
> - T in lowercase
One thing that seems I've not spotted:
What T in lowercase mean?
Is it about T as name of type (struct, class, typedef etc.)
or T as template parameter name?
For the latter, we've decided to use T or TemplParam naming. I'm a bit
confused :-)
Best regards,
-- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org
Geometry list run by mateusz at loskot.net