Subject: [ggl] spatial_index to index
From: Mateusz Loskot (mateusz)
Date: 2009-06-18 19:08:52
Barend Gehrels wrote:
> Hi Mateusz,
>> I changed the namespace name too (r828), but I'm not sure about it,
>> so please consider it as temporary change to be reviewed.
>> So, now it's ggl::index::rtree, but I'm completely unsure.
>> Probably it should be ggl:: so rtree class sits in ggl::rtree?
> Nice. The namespace index is OK to me. Folder structure is OK to me. The
> namespace rtree sounds a littlebit redundant to me.
> typedef typename ggl::index::rtree::rtree<Box, P, int> type;
> I would expect an ggl::index::rtree here, . For the implementation, it
> might go into "detail::rtree". It is then similar to the algorithms (be
> it that they are in ggl::distance, but we don't want to have ::algorithm
This is perfect.
I will apply this fix tomorrow, unless Federico wants to do it.
BTW, I've committed a bunch of changes to the spatial index yesterday,
applying our guidelines and adding some TODO comments.
p.s. I concur Hartmut's request about commits -> ggl-commits
list notifications :-)
-- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org
Geometry list run by mateusz at loskot.net