|
Geometry : |
Subject: [ggl] spatial_index to index
From: Mateusz Loskot (mateusz)
Date: 2009-06-21 18:43:55
Barend Gehrels wrote:
> Hi Mateusz,
>
>
>> I changed the namespace name too (r828), but I'm not sure about it,
>> so please consider it as temporary change to be reviewed.
>>
>> So, now it's ggl::index::rtree, but I'm completely unsure.
>> Probably it should be ggl:: so rtree class sits in ggl::rtree?
>>
>
> Nice. The namespace index is OK to me. Folder structure is OK to me. The
> namespace rtree sounds a littlebit redundant to me.
>
> typedef typename ggl::index::rtree::rtree<Box, P, int> type;
>
> I would expect an ggl::index::rtree here,
Done. Let's see if Trac notifies about my update to the ticket :-)
> For the implementation, it
> might go into "detail::rtree". It is then similar to the algorithms (be
> it that they are in ggl::distance, but we don't want to have ::algorithm
> there)
You mean ggl::detail::rtree, don't you?
I suppose we can move there rtree_leaf and rtree_node classes.
Perhaps some stuff from index/rtree/helpers.hpp too?
Federico, could you confirm?
Best regards,
-- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org
Geometry list run by mateusz at loskot.net