Geometry Boost List: [ggl] suspicious line 320 in extensions/gis/projections/proj/stere.hpp

Subject: [ggl] suspicious line 320 in extensions/gis/projections/proj/stere.hpp
From: Krzysztof Czainski (1czajnik)
Date: 2010-11-11 08:28:18

Hello,

I have been playing with converting Geographic <-> Cartesian, tried
projections. When I tried stere_ellipsoid, I found a warning on line 320.
That was yesterday at work, and I don't remember the warning, but it said
something about UB.

Anyway, when I look at this line in the current (r66490) sandbox/geometry,
it looks suspicious, so I changed it locally:
$ svn diff stere.hpp

 Index: stere.hpp
===================================================================
--- stere.hpp    (wersja 66490)
+++ stere.hpp    (kopia robocza)
@@ -316,7 +316,7 @@
             void setup_stere(Parameters& par, par_stere& proj_parm)
             {
                 proj_parm.phits = pj_param(par.params, "tlat_ts").i ?
-                    proj_parm.phits = pj_param(par.params, "rlat_ts").f :
HALFPI;
+                    pj_param(par.params, "rlat_ts").f : HALFPI;
                 setup(par, proj_parm);
             }

What do You guys think?

Regards, Kris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osgeo.org/pipermail/ggl/attachments/20101111/18ce1766/attachment.html